Merged
Conversation
for more information, see https://pre-commit.ci
khvn26
commented
Aug 26, 2025
emyller
previously approved these changes
Aug 28, 2025
Contributor
emyller
left a comment
There was a problem hiding this comment.
Looks good with non-blocking comments.
emyller
previously approved these changes
Aug 29, 2025
Contributor
emyller
left a comment
There was a problem hiding this comment.
Thanks for picking every nit!
emyller
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144, #145.
In this PR, we:
hide_disabled_flagsin Local evaluation mode.EvaluationContextandEvaluationResultusage.OfflineHandlersignature, add a new evaluation context-basedLocalOfflineHandler, and preserve an environment document-based one.This makes the Python SDK fully compatible with next major version of the engine and fully enables Context values in local evaluation mode.