Conversation
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
Member
|
Consider switching to the official pypa action + oidc? Refer to flagsmith-common as an example |
Contributor
Author
Done Replace publish workflow with official pypa action @khvn26 |
khvn26
reviewed
Apr 1, 2025
Member
|
Make sure you've added the publisher repo/workflow name in PyPI's package settings before merging this. |
Contributor
Author
Ya, already done - see PR description. |
khvn26
reviewed
Apr 1, 2025
|
|
||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| fetch-depth: 0 |
khvn26
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces third party publishing flow with the official pypa action (copied from here).
I have configured the auth on the pypi side as per the following screenshot.