[codex] Add workspace path expectation guardrails

[TabishB]

Summary

Adds a durable guardrail for the Windows path canonicalization failures that repeatedly broke the main Windows CI matrix.

Why

Workspace commands intentionally canonicalize existing paths before storing, reporting, and passing them to openers. On GitHub Windows runners, raw temp paths can use short aliases such as C:\Users\RUNNER~1\..., while Node's native realpath expands them to C:\Users\runneradmin\....

The recent failures happened because tests kept comparing raw mkdtemp/os.tmpdir() strings against values that had already gone through workspace canonicalization. Fixing individual assertions worked one at a time, but did not prevent the next similar test from reintroducing the same Windows-only failure.

Changes

• Adds test/helpers/workspace-paths.ts with canonical workspace path expectation helpers:
  • expectedExistingPath
  • expectedWorkspaceCodeWorkspacePath
  • expectedWorkspaceFolders
  • expectWorkspaceLaunchLog
• Refactors workspace command, interactive, and foundation tests to use the shared helper instead of duplicating local Windows path helpers.
• Adds test/commands/workspace-path-guard.test.ts, which fails if workspace.test.ts reintroduces direct generated workspace-folder array comparisons, direct opener launch-arg comparisons, or one-off getWorkspaceCodeWorkspacePath(expectedExistingPath(...)) assertions.

Validation

• pnpm vitest run test/commands/workspace.test.ts test/commands/workspace.interactive.test.ts test/core/workspace/foundation.test.ts test/commands/workspace-path-guard.test.ts
• pnpm test
• pnpm run build
• pnpm exec tsc --noEmit
• pnpm lint

Summary by CodeRabbit

• Tests
  • Centralized workspace path utilities into a shared test helper for easier maintenance.
  • Added guardrail tests to detect unsafe direct path assertions.
  • Expanded coverage for VS Code editor integration and launch behavior.
  • Updated existing tests to use the centralized helpers for consistent path and launch validations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 58a14000-ab12-43e2-8efe-d6b6d00f2445

📥 Commits

Reviewing files that changed from the base of the PR and between 344b87a and a079c4b.

📒 Files selected for processing (1)

• test/commands/workspace-path-guard.test.ts

---

📝 Walkthrough

Walkthrough

Consolidates workspace path normalization into a new test helper module and updates tests to use it; adds guard tests that detect direct path assertions bypassing canonical-path helpers. Changes are test-only; no public API changes.

Changes

Workspace path helpers, test refactors, and guard tests

Layer / File(s)	Summary
Helper Module Creation test/helpers/workspace-paths.ts	Adds shared test utilities for path normalization and assertions: expectedExistingPath, expectedWorkspaceCodeWorkspacePath, expectedWorkspaceFolders, expectedWorkspaceLaunchArgs, and expectWorkspaceLaunchLog.
Test Refactoring (usage) test/commands/workspace.interactive.test.ts, test/core/workspace/foundation.test.ts	Removes local expectedExistingPath implementations and import the shared helper.
Core Test Updates test/commands/workspace.test.ts	Imports helper functions; replaces hard-coded workspace folder assertions with expectedWorkspaceFolders; updates path-based error assertion to use expectedWorkspaceCodeWorkspacePath; adds a test simulating opening via VS Code with a fake code executable and validates launch log via expectWorkspaceLaunchLog.
Guard Tests test/commands/workspace-path-guard.test.ts	Adds a suite of regex-based guard tests that detect direct path/assertion shapes (forbidden patterns) and assert test sources use helper-backed canonical-path assertions instead.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fission-AI/OpenSpec#1055: Centralizes expectedExistingPath path-normalization helper and updates workspace tests.
• Fission-AI/OpenSpec#1050: Changes runtime canonicalization of workspace paths on Windows; related to test expectations added here.
• Fission-AI/OpenSpec#971: Also works with filesystem path canonicalization and test updates.

Suggested reviewers

• alfred-openspec

"A rabbit hopped in with careful paws,
tidied paths and fixed the flaws.
Helpers snug, tests guard the door—
canonical steps, forevermore. 🐇📁"

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[codex] Add workspace path expectation guardrails' directly and clearly summarizes the main change: introducing guardrails for workspace path expectations.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/workspace-path-guardrails

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/commands/workspace-path-guard.test.ts`:
- Around line 12-21: The existing negative regex checks in
workspace-path-guard.test.ts are too specific (they only look for .toEqual and
simple expressions) and can miss other forbidden assertions; update the
expect(source).not.toMatch(...) patterns (the ones referencing
".folders).toEqual(", "expect(workspaceFolders).toEqual(", the "Launch.args"
assertion, the "fs.realpathSync.native(...Launch.cwd" assertion, and the
"getWorkspaceCodeWorkspacePath(expectedExistingPath(" check) to match all common
Jest matchers and nested/complex expressions (e.g. toEqual, toStrictEqual, toBe,
toMatchObject, etc., and allow arbitrary whitespace and nested
parens/expressions) so any direct assertions against workspace folder paths or
Launch args/cwd are caught rather than only simple toEqual forms.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 003cc0b3-e4eb-40e3-bcd2-de4fef3266c5

📥 Commits

Reviewing files that changed from the base of the PR and between b642398 and 344b87a.

📒 Files selected for processing (5)

• test/commands/workspace-path-guard.test.ts
• test/commands/workspace.interactive.test.ts
• test/commands/workspace.test.ts
• test/core/workspace/foundation.test.ts
• test/helpers/workspace-paths.ts

[alfred-openspec]

Reviewed the diff and ran the focused workspace test slice locally: pnpm vitest run test/commands/workspace.test.ts test/commands/workspace.interactive.test.ts test/core/workspace/foundation.test.ts test/commands/workspace-path-guard.test.ts. The shared canonical-path helpers are a clean fix for the Windows runner short-path issue, and the guardrail test should prevent the same assertion pattern from creeping back in.