Support subtype INTERNAL fields#42
Draft
Sean-Kenneth-Doherty wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTERNALvalues for Reviva's runtime part configINTERNALname synchronized with the selected subtypeoffsetfor part/internal relationships that need themAddresses #35.
Context
Issue #35 is about IVA switches that need per-part/per-internal fields such as
offset. This implementation does not copy one shared partINTERNALnode across every selected IVA. Instead, Reviva creates a fresh runtimeINTERNALnode for the selected subtype, sets that subtype's internal name, and copies only extra fields from anINTERNALnode nested under that same subtype'sModuleIVASwitchdata.Validation
git diff --checkdotnet build Reviva.sln -c Release --no-restore /p:KSPRoot="/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program": 0 warnings, 0 errorsmethodSignature=newNameand failed to copy subtypeoffset/scalemethodSignature=newName,moduleConfigand passed withafterOffset="1.25, -2.5, 3.75"andafterScale="0.95, 0.95, 0.95"Caveat
This remains a draft because the runtime proof is a targeted headless KSP harness against the loaded part prefab/config path, not a real flight/B9 IVA switch visual smoke test in the shuttle scenario from the issue.