Skip to content

Add tests for Value column quoting in Single/SingleOrDefault queries. Fix #1234 #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdcastel wants to merge 2 commits into
base: master
Choose a base branch
from
+46 −0
Open

Add tests for Value column quoting in Single/SingleOrDefault queries. Fix #1234 #1263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e65aa
Add tests for Value column quoting in Single/SingleOrDefault queries.…
fdcastel Mar 23, 2026
fb7a19c
Address review: use positive assertions and wrap async calls in Asser…
fdcastel Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions src/FirebirdSql.EntityFrameworkCore.Firebird.Tests/Query/ElementaryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,52 @@ public async Task SelectWithCollate()
StringAssert.Contains(@"CAST(_UTF8'test' AS VARCHAR(4) CHARACTER SET UTF8) COLLATE UNICODE_CI_AI", sql);
}
}

[Test]
public async Task SqlQueryScalarSingleQuotesValueColumn()
{
await using (var db = await GetDbContext<SelectContext>())
{
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
Assert.DoesNotThrowAsync(() => query.SingleAsync());
var sql = db.LastCommandText;
StringAssert.Contains(@"""Value""", sql);
Copy link
Copy Markdown
Member

@cincuranet cincuranet May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not look like a correct match. The "Value" is always going to be there from the query in SqlQueryRaw, isn't it? So it will always match.

}
}

[Test]
public async Task SqlQueryScalarSingleOrDefaultQuotesValueColumn()
{
await using (var db = await GetDbContext<SelectContext>())
{
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE");
Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
var sql = db.LastCommandText;
StringAssert.Contains(@"""Value""", sql);
}
}

[Test]
public async Task SqlQueryScalarComposedWhereQuotesValueColumn()
{
await using (var db = await GetDbContext<SelectContext>())
{
var query = db.Database.SqlQueryRaw<int>(@"SELECT 1 AS ""Value"" FROM RDB$DATABASE").Where(x => x > 0);
Assert.DoesNotThrowAsync(() => query.LoadAsync());
var sql = db.LastCommandText;
StringAssert.Contains(@"""Value""", sql);
}
}

[Test]
public async Task EntitySingleOrDefaultQuotesIdentifiers()
Copy link
Copy Markdown
Member

@cincuranet cincuranet May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this test actually testing? Also the Take(1) before SingleOrDefaultAsync is redundant.

{
await using (var db = await GetDbContext<SelectContext>())
{
var query = db.Set<MonAttachment>().OrderBy(x => x.AttachmentId).Take(1);
Assert.DoesNotThrowAsync(() => query.SingleOrDefaultAsync());
}
}
}

class SelectContext : FbTestDbContext
Expand Down
Loading