Skip to content

Update package.json#130

Open
chriscurnow wants to merge 1 commit intoFirebaseExtended:mainfrom
4Cast:chriscurnow-patch-1
Open

Update package.json#130
chriscurnow wants to merge 1 commit intoFirebaseExtended:mainfrom
4Cast:chriscurnow-patch-1

Conversation

@chriscurnow
Copy link

Add "type": "module" to /auth/package.json to fix #129

Add "type": "module" to /auth/package.json to fix FirebaseExtended#129
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a module resolution issue within the auth package by explicitly setting its type to "module" in the package.json file. This ensures that the package is correctly interpreted as an ES module, resolving a reported bug and improving compatibility with module-aware environments.

Highlights

  • Module Type Configuration: Added the "type": "module" field to the auth/package.json file. This change explicitly declares the package as an ES module, which is crucial for modern JavaScript module resolution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link

google-cla bot commented Mar 18, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly adds the "type": "module" field to the auth/package.json file. This change is essential for explicitly declaring the package as an ES module, which directly addresses and resolves the module resolution issue described in the linked GitHub issue. The modification is syntactically correct and aligns with standard Node.js package configuration practices for ES modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rxfire/auth/index.esm.js:1 seems to be an ES Module but shipped in a CommonJS package

1 participant