Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughAdds an Accounts feature: list and detail pages with filtering, sorting, and new UI components. Introduces permissions and container selection flows, encryption/form hardening hooks, entity/query layers for credential metadata, and various utilities. Broad UI refactors replace h/w classes with size tokens, add autocomplete controls, update icons, and expand ORPC hooks. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Page as Accounts Page (Server)
participant RPC as oRPC Server
participant Client as DashboardCredentialsClient
User->>Page: Request /dashboard/accounts
Page->>RPC: fetch credentials + platforms
RPC-->>Page: initialData
Page-->>Client: Render with initialData
Client->>RPC: useCredentials/usePlatforms (stale-while-revalidate)
RPC-->>Client: Updated data
Client-->>User: Filter/Sort/Cards or Grid view
sequenceDiagram
actor User
participant Page as Credential Detail (Server)
participant RPC as oRPC Server
participant View as CredentialDetailView (Client)
User->>Page: Request /dashboard/accounts/{id}
Page->>RPC: fetch credential + platforms
RPC-->>Page: initialData
Page-->>View: Render with initialData
View->>RPC: useCredential(id)
RPC-->>View: Credential data
User->>View: Edit fields / change status / container
View->>RPC: Update mutations (status/container/save)
RPC-->>View: Success/Errors
View-->>User: Toast + Floating save toolbar state
sequenceDiagram
actor User
participant Dialog as Add Credential Dialog
participant Enc as Encryption Utils
participant RPC as oRPC Server
User->>Dialog: Submit form
Dialog->>Enc: generate key + encrypt values
Enc-->>Dialog: encrypted payload
Dialog->>RPC: create credential + metadata
RPC-->>Dialog: Result
Dialog-->>User: Success toast / reset or close
sequenceDiagram
actor User
participant Selector as ContainerSelector
participant Perm as useUserPermissions
participant RPC as oRPC Server
User->>Selector: Open popover
Selector->>Perm: Check permissions
alt Can create
Selector->>RPC: List containers (compatible)
RPC-->>Selector: Containers
User->>Selector: Create new
Selector->>RPC: Create container
RPC-->>Selector: New container
Selector-->>User: Auto-select + close
else Limited
Selector-->>User: Upgrade prompt tooltip
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~75 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
#10) * chore: added 'logs' page * chore: init components * chore(wip): list view & v0 migration * style: formatted code * feat: added 'DashboardAccountsDisplay' * feat(wip): added init version 'DashboardAccountsFilters' * perf: improved UI for 'DashboardMultiFilters' * perf: added 'platform' logo support * fix: resolved 'sort' in controls * feat: added 'EmptyState' * chore(wip): working on 'DashboardAccountListView' * chore: deleted 'TODO.md' * chore: refactor of 'DashboardAccountCardsView' * chore(DashboardAccountCardsView): fetch 'tags' * feat(wip): adding 'TagDisplay' * fix: resolved 'containerId' * dixes * chore: updated 'package.json' * chore: implemented 'cards' view FE * chore: setup 'ItemActionsDropdown' * feat(wip): individual 'account' page * feat: implemented 'BreadcrumbResourceSelect' * perf: added 'generateMetadata' * chore: updates to '404' page * chore: full refactor of 'accounts' * chore: full refactor of 'accounts' * fix: resolved 'build' errors * chore: revert on 'CredentialHeader' * feat: added 'future' pages * style: formatted code * chore: resolved reviews * style: refactor style 'CredentialHeader' * perf: added 'tooltip' in 'help' * chore: refactor 'sidebar' view * chore: refactor 'sidebar' view * perf: refactor 'sidebar' accounts * perf: refactor 'status' & 'container' * style(sidebar): enhanced 'timeline' section * perf: improved database schema of 'credentials' * Findmalek/fin 58 update the whole UI of form (#11) * perf: improved database schema of 'credentials' (#12) * chore: removed 'extra' button * Default containers (#13) * Disable Browser Auto Save (#14) * chore: review from 'coderabbit' * Edit Account Entity (#15) * chore: resolved 'todos' in view page * fix: resolved 'icons' import * Update the UI to support the otherInfo field (#16) * chore: re-style 'additional-informations' * chore: resolve bugs 'UI' * fix: resolved 'lint' errors * perf: added 'docker' database * perf: enhanced UX for key-pair * fix: resolved indvidual 'fetch' * chore(wip): prepare for huge refactor * chore(wip): resolving major issues * chore: full refactor & resolve issues * fix: resolve 'save-changes' * fix: resolve 'save-changes' fetch * perf: enhance skelton * fix: resolved update key-value * perf: password update (#17) * perf: removed 'duplicated' code - password input * fix: resolved 'tag' duplication * fix: resolved 'tag' duplication * fix: resolved 'key-value' creation * perf(wip): cleaning code * perf(duplication): removed 'EncryptedKeyValueForm' * fix: resolved 'display' of 'key-value' * fix: resolved 'edit' in 'key/pair' * fix: resolved 'infinite' loop * perf: updated 'MutationObserver' * perf: updated 'decryptedBuffer' * perf: updated comments 'useUserPermissions' * perf: removed 'duplicate' export± * perf: removed 'duplicate' export * chore: added 'READ' in 'canPerformAction' * fix: added 'CREDENTIAL' feature in 'Permissions' * perf: resolved 'merge' permission * style(format): prettier format code * fix: resolved 'awaited' floating-bar * chore: small code improvements * perf: improved 'ContainerData' * style(format): prettier format code * perf: improved 'CredentialMetadataQuery' * chore: small code improvements * fix: resolved duplicate usage tag * chore: minor changes * fix(wip): resolving review * fix: resolved review * perf: enforce usage of 'defaultContainer' for NORMAL
We always notice as soon as the user create a new credential the browser tries to save them, this behaviour is really bad UX, I want to disable it
Summary by CodeRabbit
New Features
Improvements