Skip to content

Disable Browser Auto Save#14

Merged
FindMalek merged 7 commits intofeat/account-pagefrom
findmalek/fin-62-disable-browser-auto-save
Aug 15, 2025
Merged

Disable Browser Auto Save#14
FindMalek merged 7 commits intofeat/account-pagefrom
findmalek/fin-62-disable-browser-auto-save

Conversation

@FindMalek
Copy link
Copy Markdown
Owner

@FindMalek FindMalek commented Aug 15, 2025

We always notice as soon as the user create a new credential the browser tries to save them, this behaviour is really bad UX, I want to disable it

Summary by CodeRabbit

  • New Features

    • Accounts dashboard with search, filters, sorting, and cards/grid views.
    • Credential detail page with editing, status updates, container assignment, and floating save bar.
    • Container creation dialog and breadcrumb resource selector.
    • Status badges, tag chips with hover overflow, and reusable empty states.
    • Auto-creation of default containers after signup.
    • New dashboard sections: Platforms, Containers, Tags, Logs, Initialized Vectors (placeholders).
  • Improvements

    • “View all activity” now navigates to Logs.
    • Consistent icon/element sizing; deterministic tag colors.
    • Reduced browser autofill/auto-save across forms; isolated password input with reveal/copy.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Aug 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
zero-locker 🔄 Building Preview Comment Aug 15, 2025 0:18am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds an Accounts feature: list and detail pages with filtering, sorting, and new UI components. Introduces permissions and container selection flows, encryption/form hardening hooks, entity/query layers for credential metadata, and various utilities. Broad UI refactors replace h/w classes with size tokens, add autocomplete controls, update icons, and expand ORPC hooks.

Changes

Cohort / File(s) Summary
Project rules & docs
.cursor/rules/general.mdc, TODO.md
Add global Cursor ruleset (accessibility/code-style). Remove TODO.md.
Accounts pages
app/(dashboard)/dashboard/accounts/page.tsx, app/(dashboard)/dashboard/accounts/[id]/page.tsx
Implement Accounts index (server data, metadata) and Credential detail page with metadata and Suspense skeleton.
Coming soon pages
app/(dashboard)/dashboard/{containers,iv,logs,platforms,tags}/page.tsx, app/(dashboard)/dashboard/{cards,secrets}/page.tsx
Add placeholder pages (Containers/IV/Logs/Platforms/Tags). Update stage labels for Cards/Secrets.
Auth UI tweaks
app/(auth)/{login,register}/loading.tsx, app/(auth)/login/page.tsx, components/app/{auth-login-form,auth-register-form}.tsx
Replace h/w with size tokens; disable autocomplete; registration initializes default containers; adjust spinner sizes.
Accounts listing client
components/app/{dashboard-credential-client,dashboard-credential-cards-view,dashboard-credential-grid-view,dashboard-credentials-header}.tsx, components/shared/{dashboard-multi-filters,dashboard-view-controls,empty-state,item-actions-dropdown,menu-shortcut}.tsx
New client components for listing, filtering, sorting, views, and shared menus/controls.
Credential detail UI
components/app/{dashboard-credential-detail-view,dashboard-credential-detail-skeleton,dashboard-credential-form,dashboard-credential-header,dashboard-credential-sidebar,dashboard-credential-footer}.tsx, components/shared/{encrypted-key-value-form,floating-save-toolbar,status-badge,tag-display}.tsx
Add detail view, form, header/sidebar/footer, skeleton, encrypted KV editor, floating save bar, status badge, tag display.
Add dialogs/forms updates
components/app/{dashboard-add-credential-dialog,dashboard-add-card-dialog,dashboard-add-secret-dialog}.tsx, components/app/{dashboard-add-credential-form.tsx, dashboard-add-credential-metadata-form.tsx} (deleted), components/app/dashboard-add-card-form.tsx, components/app/dashboard-create-container-dialog.tsx
Refactor Add Credential into responsive dialog with encryption, metadata, tags; prevent autosave; add container create dialog; delete old credential forms; apply deterministic tag colors and autocomplete hints.
Breadcrumb enhancements
components/layout/{dashboard-dynamic-breadcrumb,breadcrumb-resource-select}.tsx, lib/utils/breadcrumb-helpers.ts
Add resource-aware breadcrumb with inline selector; helpers to detect resource pages/types.
Container selection & permissions
components/shared/{container-selector,upgrade-prompt}.tsx, lib/permissions/{hooks/use-user-permissions,types,utils,index}.ts, middleware/permissions.ts, orpc/hooks/use-containers.ts, lib/utils/default-containers.ts, components/app/auth-register-form.tsx
Introduce permission system and middleware; container selector with create flow and limits; default containers utilities and hooks; run initialization post-signup.
Entities and queries
entities/credential/credential-key-value/*, entities/credential/credential/{entity,query}.ts, entities/credential/index.ts, entities/encryption/{entity,index}.ts, entities/utils/container/entity.ts, entities/credential/credential-metadata/entity.ts
Add credential KV pair entity/query; credential include Ro with tags; encryption select; container helpers and isDefault; remove otherInfo from metadata Ro.
ORPC hooks enhancements
orpc/hooks/{use-credentials,use-platforms,use-cards,use-secrets}.ts
Add optional React Query options; new useCredentialPassword; placeholderData and customizations.
Security, encryption, forms
lib/encryption.ts, hooks/{use-prevent-auto-save,use-aggressive-form-blocker}.ts, components/shared/isolated-password-input.tsx, components/ui/input.tsx
Support AES-GCM/CBC in Node; hooks to block autosave/submits; isolated password input; new password-copyable input variant.
Utilities
lib/{date-utils.ts,constants.ts}, lib/utils/{index.ts,color-helpers.ts,tag-helpers.ts}
Add date helpers, grid constants; deterministic tag color helpers and exports; update tag creation to use generated colors.
UI/icon/style tweaks
components/shared/{icons,coming-soon,add-item-dialog,add-item-dropdown,card-icon,card-payment-inputs,card-status-indicator,upgrade-prompt}.tsx, components/app/{dashboard-overview-stats,marketing-features,marketing-how-it-works,marketing-waitlist-form,dashboard-recent-activity}.tsx, components/layout/{dashboard-sidebar,dashboard-nav-user,dashboard-search-combobox}.tsx, components/ui/{badge,chart,combobox-responsive,input-otp,menubar,navigation-menu}.tsx, app/not-found.tsx, next.config.ts
Expand icon set/mappings; unify size classes; add Badge info variant; minor UI tweaks; remove 404 image; allow avatar.vercel.sh images.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant Page as Accounts Page (Server)
  participant RPC as oRPC Server
  participant Client as DashboardCredentialsClient
  User->>Page: Request /dashboard/accounts
  Page->>RPC: fetch credentials + platforms
  RPC-->>Page: initialData
  Page-->>Client: Render with initialData
  Client->>RPC: useCredentials/usePlatforms (stale-while-revalidate)
  RPC-->>Client: Updated data
  Client-->>User: Filter/Sort/Cards or Grid view
Loading
sequenceDiagram
  actor User
  participant Page as Credential Detail (Server)
  participant RPC as oRPC Server
  participant View as CredentialDetailView (Client)
  User->>Page: Request /dashboard/accounts/{id}
  Page->>RPC: fetch credential + platforms
  RPC-->>Page: initialData
  Page-->>View: Render with initialData
  View->>RPC: useCredential(id)
  RPC-->>View: Credential data
  User->>View: Edit fields / change status / container
  View->>RPC: Update mutations (status/container/save)
  RPC-->>View: Success/Errors
  View-->>User: Toast + Floating save toolbar state
Loading
sequenceDiagram
  actor User
  participant Dialog as Add Credential Dialog
  participant Enc as Encryption Utils
  participant RPC as oRPC Server
  User->>Dialog: Submit form
  Dialog->>Enc: generate key + encrypt values
  Enc-->>Dialog: encrypted payload
  Dialog->>RPC: create credential + metadata
  RPC-->>Dialog: Result
  Dialog-->>User: Success toast / reset or close
Loading
sequenceDiagram
  actor User
  participant Selector as ContainerSelector
  participant Perm as useUserPermissions
  participant RPC as oRPC Server
  User->>Selector: Open popover
  Selector->>Perm: Check permissions
  alt Can create
    Selector->>RPC: List containers (compatible)
    RPC-->>Selector: Containers
    User->>Selector: Create new
    Selector->>RPC: Create container
    RPC-->>Selector: New container
    Selector-->>User: Auto-select + close
  else Limited
    Selector-->>User: Upgrade prompt tooltip
  end
Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~75 minutes

Possibly related PRs

Poem

In the warren of code, I hop with glee,
New accounts bloom bright as a carrot tree.
Filters and tags in a tidy row,
Secrets encrypted where breezes blow.
Containers nest like burrows neat—
Permissions guard each hidden treat. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch findmalek/fin-62-disable-browser-auto-save

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@FindMalek FindMalek changed the base branch from main to feat/account-page August 15, 2025 00:18
@FindMalek FindMalek merged commit 130a14c into feat/account-page Aug 15, 2025
1 of 3 checks passed
FindMalek added a commit that referenced this pull request Sep 30, 2025
#10)

* chore: added 'logs' page

* chore: init components

* chore(wip): list view & v0 migration

* style: formatted code

* feat: added 'DashboardAccountsDisplay'

* feat(wip): added init version 'DashboardAccountsFilters'

* perf: improved UI for 'DashboardMultiFilters'

* perf: added 'platform' logo support

* fix: resolved 'sort' in controls

* feat: added 'EmptyState'

* chore(wip): working on 'DashboardAccountListView'

* chore: deleted 'TODO.md'

* chore: refactor of 'DashboardAccountCardsView'

* chore(DashboardAccountCardsView): fetch 'tags'

* feat(wip): adding 'TagDisplay'

* fix: resolved 'containerId'

* dixes

* chore: updated 'package.json'

* chore: implemented 'cards' view FE

* chore: setup 'ItemActionsDropdown'

* feat(wip): individual 'account' page

* feat: implemented 'BreadcrumbResourceSelect'

* perf: added 'generateMetadata'

* chore: updates to '404' page

* chore: full refactor of 'accounts'

* chore: full refactor of 'accounts'

* fix: resolved 'build' errors

* chore: revert on 'CredentialHeader'

* feat: added 'future' pages

* style: formatted code

* chore: resolved reviews

* style: refactor style 'CredentialHeader'

* perf: added 'tooltip' in 'help'

* chore: refactor 'sidebar' view

* chore: refactor 'sidebar' view

* perf: refactor 'sidebar' accounts

* perf: refactor 'status' & 'container'

* style(sidebar): enhanced 'timeline' section

* perf: improved database schema of 'credentials'

* Findmalek/fin 58 update the whole UI of form (#11)

* perf: improved database schema of 'credentials' (#12)

* chore: removed 'extra' button

* Default containers (#13)

* Disable Browser Auto Save (#14)

* chore: review from 'coderabbit'

* Edit Account Entity (#15)

* chore: resolved 'todos' in view page

* fix: resolved 'icons' import

* Update the UI to support the otherInfo field (#16)

* chore: re-style 'additional-informations'

* chore: resolve bugs 'UI'

* fix: resolved 'lint' errors

* perf: added 'docker' database

* perf: enhanced UX for key-pair

* fix: resolved indvidual 'fetch'

* chore(wip): prepare for huge refactor

* chore(wip): resolving major issues

* chore: full refactor & resolve issues

* fix: resolve 'save-changes'

* fix: resolve 'save-changes' fetch

* perf: enhance skelton

* fix: resolved update key-value

* perf: password update (#17)

* perf: removed 'duplicated' code - password input

* fix: resolved 'tag' duplication

* fix: resolved 'tag' duplication

* fix: resolved 'key-value' creation

* perf(wip): cleaning code

* perf(duplication): removed 'EncryptedKeyValueForm'

* fix: resolved 'display' of 'key-value'

* fix: resolved 'edit' in 'key/pair'

* fix: resolved 'infinite' loop

* perf: updated 'MutationObserver'

* perf: updated 'decryptedBuffer'

* perf: updated comments 'useUserPermissions'

* perf: removed 'duplicate' export±

* perf: removed 'duplicate' export

* chore: added 'READ' in 'canPerformAction'

* fix: added 'CREDENTIAL' feature in 'Permissions'

* perf: resolved 'merge' permission

* style(format): prettier format code

* fix: resolved 'awaited' floating-bar

* chore: small code improvements

* perf: improved 'ContainerData'

* style(format): prettier format code

* perf: improved 'CredentialMetadataQuery'

* chore: small code improvements

* fix: resolved duplicate usage tag

* chore: minor changes

* fix(wip): resolving review

* fix: resolved review

* perf: enforce usage of 'defaultContainer' for NORMAL
@coderabbitai coderabbitai Bot mentioned this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant