Closed
Conversation
lukkas
requested review from
damian-kaczmarek and
joachimschmidt
as code owners
Collaborator
|
I pinged the author on original package PR with fix optimizely#98 |
Collaborator
Author
Perfect 👌 I'll close this and integrate the changes tomorrow. |
Collaborator
Author
|
git replaced with: #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should fix the crash: https://findhotel.sentry.io/issues/7245666115/?project=4508398661074946
We dispatch the callback from SDK initialization back to the main thread.
Looks that the Swift SDK can call us back on an arbitrary queue, while it should be the main queue the communicate via Flutter channels as far as I am aware.
Also, there's some state modification in that callback block, which doesn't look like it's thread safe.
When investigating the Swift SDK I could confirm, that the work is dispatcher on the background thread and never disptached back to main when calling bak the original start caller:
https://github.com/optimizely/swift-sdk/blob/fdefe531d3c4c44eff7f77f7d32dd20fbfd984e5/Sources/Optimizely/OptimizelyClient.swift#L146
https://github.com/optimizely/swift-sdk/blob/fdefe531d3c4c44eff7f77f7d32dd20fbfd984e5/Sources/Customization/DefaultDatafileHandler.swift#L67