refactor: viem in session key and endorsements #571
+490
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 38436fc | Commit Preview URL Branch Preview URL |
Jan 27 2026, 01:00 PM |
rvagg
reviewed
Jan 27, 2026
packages/synapse-core/src/chains.ts
Outdated
| abi: typeof Abis.pdp | ||
| } | ||
| endorsements: { | ||
| providerIdSet: { |
Collaborator
There was a problem hiding this comment.
This probably isn't what we want to do, as @wjmelements pointed out previously this is a generic utility contract that just happens to be applied to the endorsements use-case at the particular address its deployed at. We could potentially deploy an identical contract impl to a new address and use it for the approved providers list. So I'd vote for keeping it as "endorsements" or even more verbose, something like "endorsedProvidersSet".
- Introduced a new `authorizationExpiry` function to retrieve the expiration timestamp for session key permissions, improving session management capabilities. - Updated session key actions to utilize the new `authorizationExpiry` function, enhancing clarity and reducing redundancy in code. - Renamed `sessionAddress` to `sessionKeyAddress` for consistency across session key-related functions. - Added comprehensive tests for the `authorizationExpiry` functionality, ensuring reliability and correctness in various scenarios. - Updated documentation to reflect changes in session key handling and improve overall clarity.
…handling - Refactored the Synapse class to utilize a connector client for the EndorsementsService, enhancing integration with the new client architecture. - Simplified the EndorsementsService constructor to accept a client instead of a provider and endorsements address, improving flexibility. - Updated the SessionKey class to align with the new client structure, enhancing session key management and functionality. - Revised tests to accommodate changes in session key creation and validation, ensuring consistency and reliability in the testing framework.
- Modified the endorsements retrieval in the endorse command to use providerIdSet for improved contract integration. - Updated the payment command to retrieve the address using getClient instead of getSigner, enhancing clarity in client interactions.
- Updated the endorse command to retrieve endorsements from the correct contract structure. - Refactored chain definitions to replace providerIdSet with endorsements for improved clarity. - Adjusted constants in the JSON-RPC mock to align with the new endorsements structure. - Modified the EndorsementsService to utilize the updated endorsements address and ABI.
- Updated the Filecoin Calibration Filscan contract addresses in the generated ABI file to reflect the correct values. - Ensured consistency across documentation by aligning the contract references with the updated addresses.
- Upgraded the viem library version in the pnpm workspace configuration to ensure compatibility with the latest features and improvements.
hugomrdias
force-pushed
the
hugomrdias/session-key
branch
from
0f7de8e to
38436fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.