-
Notifications
You must be signed in to change notification settings - Fork 23
refactor: move FilBeam domain to chain configuration #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace hardcoded chainId check in createPieceUrl with chain configuration lookup. Add filbeam.retrievalDomainName to Chain interface and configure it for mainnet, calibration, and devnet. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
b95801b to
39f49e0
Compare
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
synapse-dev | 0551853 | Jan 27 2026, 01:11 PM |
add ENDORSEMENTS_ADDRESS env config to utils/example-storage-e2e.js
chore: fix identifier
|
seems good to me, although I hope that devnet address isn't important for the standard path because so many things want to listen to |
Yeah, I share your concern. Actually, FilBeam does not support local devnet. It would be nice to throw a helpful error when trying to retrieve a devnet piece via FilBeam, but it's not clear to me how to achieve that and I feel this is not worth our effort right now. |
|
there is the filbeam retriever in synapse-sdk, maybe it should be pulling the base address from the chain? in that case, a better port number might be advisable because I think we include it in the default retrieval path |
|
How do you feel about using |
hugomrdias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a suggestion for the prop name
packages/synapse-core/src/chains.ts
Outdated
| } | ||
| } | ||
| filbeam: { | ||
| retrievalDomainName: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| retrievalDomainName: string | |
| retrievalDomain: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed in daa9035
I will follow-up with another PR |
|
The follow-up PR: |
Summary
filbeam.retrievalDomainNameproperty to theChaininterfacefilbeam.io), calibration (calibration.filbeam.io), and devnet (localhost:8080)createPieceUrlto use chain configuration instead of hardcoded chainId checkChaininstead ofchainIdTest plan
createPieceUrlcovering all three chains