chore: re-add getMaxProvingPeriod and challengeWindow function
#550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
requested changes
Jan 19, 2026
github-project-automation
bot
moved this from 🔎 Awaiting review
to ⌨️ In Progress
in FOC
hugomrdias
approved these changes
Jan 20, 2026
This was referenced Jan 19, 2026
Contributor
|
Why did we do this? |
Contributor
I have found the prior discussion and commented. I will be reverting this in #553 |
wjmelements
added a commit
that referenced
this pull request
Jan 20, 2026
* Baseline super-good-enough cert Signed-off-by: Jakub Sztandera <oss@kubuxu.com> * stub decodeEndorsements * preferEndorsements * start decoding endorsements Signed-off-by: Jakub Sztandera <oss@kubuxu.com> * notAfter as timesetamp * encodeEndorsements * mv cert.ts to utils * utils export from cert.ts * fix test * test that createContexts prefers endorsements * encode/decode certs with domain separator * add cert test * add tools/endorse-sp.js * increase timeout for CI * make the decodeEndorsements a bit simpler Signed-off-by: Jakub Sztandera <oss@kubuxu.com> * add more tests Signed-off-by: Jakub Sztandera <oss@kubuxu.com> * Update packages/synapse-core/src/utils/cert.ts Co-authored-by: Jakub Sztandera <oss@kubuxu.com> * rm sinon * Update packages/synapse-core/src/utils/cert.ts Co-authored-by: Rod Vagg <rod@vagg.org> * cleanup * Update packages/synapse-core/src/utils/cert.ts Co-authored-by: Rod Vagg <rod@vagg.org> * disallow undefined chainId in decodeEndorsement * accept any of the preferred endorsements * remove certs * wagmi * constants * EndorsementsService * plumbing * import type * add endorsements mock and restore test * add endorsements script to examples/cli * delete keystore when init with pk * Revert "delete keystore when init with pk" This reverts commit c76237c. * fix lint * isCancel * serviceURL * lint * decodePDPCapabilities is not async * Revert "chore: re-add `getMaxProvingPeriod` and `challengeWindow` function (#550)" This reverts commit 62bb92a. * getContract * test fallback on ping failure --------- Signed-off-by: Jakub Sztandera <oss@kubuxu.com> Co-authored-by: Jakub Sztandera <oss@kubuxu.com> Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-added the functions removed in #526