feat: add Service Offered to Service Providers#214
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
barbaraperic
left a comment
barbaraperic
left a comment
There was a problem hiding this comment.
Works well 🎉, left a few comments
| id: keyof ServiceProvider | ||
| value: Array<string> | Range | ||
| id: keyof ServiceProvider | 'serviceOffered' | ||
| value: Array<string> | Array<ServiceTier> | Range |
There was a problem hiding this comment.
The ServiveProviderColumnFilters type defines value: Array<ServiceTier>, but at runtime serviceTier is actually Array<number> (e.g., [1] instead of [ServiceTier.PDP_ONLY])?
There was a problem hiding this comment.
This looks like expected behavior. ServiceTier is a numeric enum, so Array<ServiceTier> is represented as Array<number> at runtime (e.g. [ServiceTier.PDP_ONLY] → [1]). The typing is still correct.
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
|
@barbaraperic Anything blocking merging this? |
Looks good to me 👍 |
|
@silent-cipher seems to be a small conflict coming from the other PR that got merged, want to resolve this so we can get it merged? |
4 participants
📝 Description
This PR add a
Service Offeredcolumn to service providers table.🛠️ Key Changes
getServiceTier()utility function - to determine consistent tierService Offeredcolumn - enables sorting by tier ( Warm & PDP > PDP only > Inactive )Service Offeredfilter📸 Screenshots
Closes #133