Open
Conversation
Owner
Author
|
Requesting review from @pablogsal and @taegyunkim |
taegyunkim
reviewed
May 9, 2025
Comment on lines
+14
to
+15
| 1. Traversing the all frames in a thread state is expensive, as | ||
| the frame layout is roughly a linked list. |
There was a problem hiding this comment.
Isn't this resolved by the introduction of _PyStackChunk? or am I misreading what is meant by frames here?
_PyStackChunk is still a linked list, but is much better than copying all _PyInterpreterFrame.
Owner
Author
There was a problem hiding this comment.
Yeah it's a bit subtle, that's what I meant by "roughly" a linked list :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.