Skip to content

Comments

Remove bauble shield copied shield handling via onLivingAttack#11

Open
cdstk wants to merge 1 commit intoFermiumModding:mainfrom
cdstk:bauble-shield-fix+
Open

Remove bauble shield copied shield handling via onLivingAttack#11
cdstk wants to merge 1 commit intoFermiumModding:mainfrom
cdstk:bauble-shield-fix+

Conversation

@cdstk
Copy link
Contributor

@cdstk cdstk commented Sep 2, 2025

Better version of the disaster from my previous FermiumModding/RLMixins#35

Removes the modified copy of vanilla shield handling onLivingAttack, which caused increased durability damage that could rapidly destroy the shield from an attack that was active every tick.

Restores the intended 0 durability unusable state as it was intended to never be breakable like an Elytra.

@fonnymunkey
Copy link
Member

Im confused on this patch, the original code appears it would only prevent damage over 5 from breaking the shield, but damage less than 5 would still break it
With the patch it seems like it would just make the shield never break, but I dont see where it would also make it unusable

@cdstk
Copy link
Contributor Author

cdstk commented Feb 20, 2026

Im confused on this patch, the original code appears it would only prevent damage over 5 from breaking the shield, but damage less than 5 would still break it With the patch it seems like it would just make the shield never break, but I dont see where it would also make it unusable

The shield being unusable is already implemented in Bountiful Baubles
ItemShieldCobalt.java Line 76

BB intended for the Shield to never break but become unusable at 0 durability remaining. onLivingAttack tries to limits dura damage dealt to the Shield to the point that it will trigger the unusable condition, but will not be broken.
ItemShieldCobalt.java Line 115

Discord report with video of fast Dura Shred
https://discord.com/channels/199155955206717440/1335775074216837120
The custom onLivingAttack handling leads to cases where the Shield would rapidly delete durability.
Thread also contains video of modified Bauble Shield behavior which solely uses Vanilla/ShieldBreak handling
https://discord.com/channels/199155955206717440/1335775074216837120/1338361568798445671

When using ShieldBreak, a Bauble Shield would run both the original custom onLivingAttack handling and ShieldBreak's handling, thus making the Shield take extra dura damage to fully break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants