Improve shutdown behavior, config error messages, fix memory/FTS5 bugs #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Memory extraction was failing with:
SqliteError: NOT NULL constraint failed: memory_entities.entity_type
Root cause: Function signature mismatch in extractor.js:105
- trackEntity() expects a single object parameter: { type, name, context }
- Code was passing positional arguments: trackEntity('code', entityName, {...})
Fix: Changed call to use correct object signature:
store.trackEntity({
type: 'code',
name: entityName,
context: { source: 'extraction' }
});
Testing:
- Server starts without errors
- Test requests complete successfully
- No database constraint violations in logs
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…acters
Enhanced the prepareFTS5Query() function to sanitize all special characters
that could cause FTS5 syntax errors, including pipes (|), commas (,), and
other punctuation marks that appear in markdown tables and formatted text.
Changes:
- Expanded character removal regex to include: | , + = ? ! ; / \ @ # $ % ^ & { }
- Added additional safety check to remove any remaining non-alphanumeric characters
- Prevents "fts5: syntax error near ','" errors when searching with complex queries
The fix resolves FTS5 syntax errors that occurred when Claude CLI sent
messages containing markdown tables or other formatted text with special
characters.
Improves shutdown behavior to stop server within 2-3 seconds instead of 30+. Changes: - Make SIGINT/SIGTERM handlers async and await shutdown - Add getShuttingDown() getter to health module - Check shutdown flag at start of each agent loop iteration - Return graceful 503 response when shutting down This enables quick interruption of ongoing requests during server shutdown without waiting for full request timeout. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ROVIDER is specified Previously, setting MODEL_PROVIDER to an invalid value like "openaix" would silently fall back to "databricks" and then throw a misleading Databricks credential error. Users would see "Set DATABRICKS_API_BASE and DATABRICKS_API_KEY" instead of being informed about the invalid provider value. Changes: - Add explicit validation for MODEL_PROVIDER before provider-specific checks - Add explicit validation for FALLBACK_PROVIDER with same pattern - Throw clear error listing all valid options when invalid provider specified - Show original (case-preserved) value in error to help identify typos - Add comprehensive test suite with 18 test cases covering all providers Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The error message format was improved in bf657d5 to be more user-friendly. Updated test regex to match new format: 'Unsupported FALLBACK_PROVIDER.*Valid options are' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
|
Thank you for the PR it helps us to fix a long standing issue with FTS5 bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes/enhancements