Skip to content

Make Observables inherit from each other #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FancyNeuron merged 1 commit into from
Jun 12, 2025
Merged

Make Observables inherit from each other #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/spellbind/observables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def unobserve(self, observer: Observer) -> None:
raise NotImplementedError


class ValueObservable(Generic[_S], ABC):
class ValueObservable(Observable, Generic[_S], ABC):
@abstractmethod
def observe(self, observer: Observer | ValueObserver[_S], times: int | None = None) -> None:
raise NotImplementedError
Expand All @@ -125,7 +125,7 @@ def unobserve(self, observer: Observer | ValueObserver[_S]) -> None:
raise NotImplementedError


class BiObservable(Generic[_S, _T], ABC):
class BiObservable(ValueObservable[_S], Generic[_S, _T], ABC):
@abstractmethod
def observe(self, observer: Observer | ValueObserver[_S] | BiObserver[_S, _T],
times: int | None = None) -> None:
Expand All @@ -141,7 +141,7 @@ def unobserve(self, observer: Observer | ValueObserver[_S] | BiObserver[_S, _T])
raise NotImplementedError


class TriObservable(Generic[_S, _T, _U], ABC):
class TriObservable(BiObservable[_S, _T], Generic[_S, _T, _U], ABC):
@abstractmethod
def observe(self, observer: Observer | ValueObserver[_S] | BiObserver[_S, _T] | TriObserver[_S, _T, _U],
times: int | None = None) -> None:
Expand Down