fix(props): update fluid-on-mobile value on pass through#139
Merged
emmclaughlin merged 1 commit intomainfrom Feb 4, 2026
Merged
fix(props): update fluid-on-mobile value on pass through#139emmclaughlin merged 1 commit intomainfrom
emmclaughlin merged 1 commit intomainfrom
Conversation
awaterston01
approved these changes
Jan 27, 2026
emmclaughlin
force-pushed
the
evan/fix-fluid-on-mobile-prop
branch
from
c3c9b89 to
b59a7ea
Compare
|
Hi! thanks for the fix Would it be possible to cut a new release that includes this fix? I'm blocked on it in a project and would really appreciate it. Thanks for maintaining this library |
Collaborator
Author
Thank you for the nudge, and sorry for the delay. It should be available in 3.5.4: https://github.com/Faire/mjml-react/releases/tag/v3.5.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mjml documentation has fluid-on-mobile as a boolean, which is different to similar attributes like full-width which take "full-width" or false (ref).
This change makes fluidOnMobile pass through the boolean value to fix #138