De-boostify: use std::pmr from C++17

[ktf]

No description provided.

[ktf]

@dennisklein @rbx any objections to this? I am trying to de-boostify, this since pmr is now in the standard (C++20). Would that be ok with you?

[coderabbitai]

📝 Walkthrough

Walkthrough

The code in fairmq/MemoryResources.h was updated to replace the Boost polymorphic memory resource header with the standard C++17 <memory_resource> header and changed the pmr namespace alias from boost::container::pmr to std::pmr.

Changes

File(s)	Change Summary
fairmq/MemoryResources.h	Replaced Boost PMR header with standard <memory_resource> and updated pmr namespace alias to std::pmr.

Sequence Diagram(s)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c961ba8 and e4bb472.

📒 Files selected for processing (1)

• fairmq/MemoryResources.h (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• fairmq/MemoryResources.h

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ktf]

Actually it looks like it's in C++17 already, maybe we can even remove the ifdef, then?

[dennisklein]

• 👍 to de-boostify
• I wouldn't mind, if we bumped required C++ to C++20.
• If you can confirm this works with the Alice-relevant GCC and (Apple)Clang versions, let's remove the #ifdef.

[ktf]

I am working on making O2 able to digest both. Apparently there are some subtle changes which require minor adaptations, see: AliceO2Group/AliceO2#14384 and AliceO2Group/AliceO2#14379. I am now checking everything is in order and let you know.

[ktf]

alisw/alidist#5922 is the last remaining bit. If this passes tests, I would claim we (ALICE) can use both std::pmr and boost::container::pmr independently. Once that's validated, I would kindly ask you for an official tag with this.

[ktf]

Actually, it looks like trying with a private commit confuses CMake. Can you please tag this? Otherwise I get:

## sw/BUILD/Control-OCCPlugin-latest/log
--
CMake Error at CMakeLists.txt:154 (find_package):
  Could not find a configuration file for package "FairMQ" that is compatible
  with requested version "1.4.2".

  The following configuration files were considered but not accepted:

    /sw/slc9_x86-64/FairMQ/v1.10.0-local1/lib/cmake/FairMQ-1.2.2/FairMQConfig.cmake, version: 1.2.2

when I use a hash.