Skip to content

Conversation

@ishaankalra
Copy link
Collaborator

@ishaankalra ishaankalra commented Dec 30, 2025

Description

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have created feat/bugfix branch out of develop branch
  • Code passes linting/formatting checks
  • Changes to resources have been tested in our dev environments
  • I have made corresponding changes to the documentation

Testing

Reviewer instructions

Summary by CodeRabbit

Release Notes

  • New Features
    • Exposed IAM role name and ARN as module outputs, enabling direct reference by other infrastructure components for enhanced integration and configuration management.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Added two new keys to the locals.output_attributes map in the AWS IAM role module outputs: iam_role_name and iam_role_arn, mapped from module.iam_eks_role outputs. The existing irsa_iam_role_arn mapping remains unchanged.

Changes

Cohort / File(s) Summary
Output Attributes Enhancement
modules/aws_iam_role/default/0.2/outputs.tf
Added iam_role_name and iam_role_arn keys to locals.output_attributes map, sourced from module.iam_eks_role module outputs

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4aed62f and 7431432.

📒 Files selected for processing (1)
  • modules/aws_iam_role/default/0.2/outputs.tf

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishaankalra ishaankalra merged commit 441efa4 into master Dec 30, 2025
1 of 2 checks passed
@ishaankalra ishaankalra deleted the aws-iam-irsa-fix branch December 30, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants