Skip to content

Azure modules revamp #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ShrinidhiFCTS23 wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Azure modules revamp #431

ShrinidhiFCTS23 wants to merge 36 commits into from

Conversation

@ShrinidhiFCTS23
Copy link
Contributor

@ShrinidhiFCTS23 ShrinidhiFCTS23 commented Jul 1, 2025

Description

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have created feat/bugfix branch out of develop branch
  • Code passes linting/formatting checks
  • Changes to resources have been tested in our dev environments
  • I have made corresponding changes to the documentation

Testing

Reviewer instructions

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 1, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch azure-modules-revamp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ishaankalra ishaankalra force-pushed the azure-modules-revamp branch from dd7b0f7 to 3f3135d Compare July 23, 2025 10:17
pramodh-ayyappan
pramodh-ayyappan reviewed Jul 23, 2025
View reviewed changes
modules/kubernetes_cluster/azure_aks/0.2/facets.yaml
resource_type: network
resource_name: default
cloud_account:
type: '@outputs/cloud_account'
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use flavor specific cloud account

modules/kubernetes_cluster/azure_aks/0.2/facets.yaml
providers:
- azurerm
outputs:
default:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the attributes/interfaces output name instead of default

@ishaankalra ishaankalra force-pushed the azure-modules-revamp branch from 3f3135d to 9415a95 Compare August 4, 2025 09:51
pramodh-ayyappan
pramodh-ayyappan requested changes Aug 6, 2025
View reviewed changes
modules/kubernetes_cluster/azure_aks/0.2/facets.yaml
flavor: azure_aks_cluster
alias-flavors:
- default
version: '0.2'
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have a different flavor and version so that exsiting modules won't get an upgrade option

modules/kubernetes_cluster/azure_aks/0.2/facets.yaml
description: Configuration for the AKS cluster.
x-ui-toggle: false
properties:
kubernetes_version:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep auto upgrade by default and remove this attribute.

modules/kubernetes_cluster/azure_aks/0.2/facets.yaml
- authenticator
- controllerManager
- scheduler
sku_tier:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just review the attributes once whether it should be overrides only or overrides disabled

modules/network/azure_vpc/0.2/facets.yaml
x-ui-overrides-only: true
x-ui-error-message: CIDR must be a valid IP block (e.g., 10.0.0.0/16)
x-ui-placeholder: 10.0.0.0/16
region:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the dropdown to select region

modules/network/azure_vpc/0.2/facets.yaml
title: Azure Region
description: Azure region where the VNet will be created
x-ui-overrides-only: true
availability_zones:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the dropdown to azs based on region

modules/network/azure_vpc/0.2/facets.yaml
type: string
minItems: 1
maxItems: 3
use_fixed_cidr_allocation:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use of this?

modules/network/azure_vpc/0.2/facets.yaml
- '1024'
- '2048'
- '4096'
- '8192'
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a /16 cidr and use the max in each type of subnets

modules/network/azure_vpc/0.2/facets.yaml
default: single
required:
- strategy
private_endpoints:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try and see if we can have additional custom endpoints can be passed?

modules/network/azure_vpc/0.2/facets.yaml
outputs:
default:
type: '@facets/azure-network-details'
sample:
Copy link
Collaborator

@pramodh-ayyappan pramodh-ayyappan Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only keep the mandatory fields in the sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pramodh-ayyappan pramodh-ayyappan pramodh-ayyappan requested changes

@rr0hit rr0hit Awaiting requested review from rr0hit rr0hit will be requested when the pull request is marked ready for review rr0hit is a code owner

@anshulsao anshulsao Awaiting requested review from anshulsao anshulsao will be requested when the pull request is marked ready for review anshulsao is a code owner

@vishnukv-facets vishnukv-facets Awaiting requested review from vishnukv-facets vishnukv-facets will be requested when the pull request is marked ready for review vishnukv-facets is a code owner

@ishaankalra ishaankalra Awaiting requested review from ishaankalra ishaankalra will be requested when the pull request is marked ready for review ishaankalra is a code owner

@unni-facets unni-facets Awaiting requested review from unni-facets unni-facets will be requested when the pull request is marked ready for review unni-facets is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShrinidhiFCTS23 @pramodh-ayyappan @ishaankalra