removed alias-flavor for cluster, network and account #392

ShrinidhiFCTS23 · 2025-06-03T07:00:25Z

Description

Related issues

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I have created feat/bugfix branch out of develop branch
Code passes linting/formatting checks
Changes to resources have been tested in our dev environments
I have made corresponding changes to the documentation

Testing

Reviewer instructions

coderabbitai · 2025-06-03T07:00:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

facets-saas

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

This reverts commit a6777ed.

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean

This reverts commit a6777ed.

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output

* added artifactories module * updates to vault module * removed facets yaml outputs * added gitignore files * Cleaned up ignored files * Cleaned up ignored files * Cleaned up ignored files * added artifactories module * updated to vault facets.yaml * terraform fmt * deleted zip_modules.py * updated module source

(cherry picked from commit 122c9dc28b355bfe612e98f026decf2195beb507)

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable.

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean

This reverts commit a6777ed.

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable.

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch

* github actions fixes * changed the env variable name

This reverts commit 9dbcda0.

* added outputs for vpc * fixed outputs

* removed outputs from intent/network * added default outputs from intent/network

This reverts commit 46e158b.

This reverts commit 509287b.

* if price is 0, exclude from dataset (#174) * if price is 0, exclude from dataset * removed .DS_Store * added generated files * removed incorrect files (#176) * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * if price is 0, exclude from dataset (#174) * if price is 0, exclude from dataset * removed .DS_Store * added generated files * removed incorrect files (#176) * [S73] Feature: Per-Instance Artifactories Module (#210) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#215) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output * Artifactories Terraform Module (#228) * added artifactories module * updates to vault module * removed facets yaml outputs * added gitignore files * Cleaned up ignored files * Cleaned up ignored files * Cleaned up ignored files * added artifactories module * updated to vault facets.yaml * terraform fmt * deleted zip_modules.py * updated module source * updated to work with github app (cherry picked from commit 122c9dc28b355bfe612e98f026decf2195beb507) * Innersourcing workflows (#230) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Innersourcing workflows update (#231) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable. * if price is 0, exclude from dataset (#174) * if price is 0, exclude from dataset * removed .DS_Store * added generated files * removed incorrect files (#176) * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#215) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output * Artifactories Terraform Module (#228) * added artifactories module * updates to vault module * removed facets yaml outputs * added gitignore files * Cleaned up ignored files * Cleaned up ignored files * Cleaned up ignored files * added artifactories module * updated to vault facets.yaml * terraform fmt * deleted zip_modules.py * updated module source * Innersourcing workflows (#230) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Innersourcing workflows update (#231) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable. * added github workflows for validate bootrapper (#245) * Validate bootstraper (#246) * added github workflows for validate bootrapper * added step for trigger validate-bootstrapper in publish.yml * changed the trigger name * using workflow_runs * using workflow_runs conclusion * Github actions fixes (#249) * github actions fixes * changed the env variable name * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#210) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#215) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output * Validate bootstraper (#246) * added github workflows for validate bootrapper * added step for trigger validate-bootstrapper in publish.yml * changed the trigger name * using workflow_runs * sync with innersourcing * Config modules for db users (#255) * [S73] Feature: Per-Instance Artifactories Module (#210) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#210) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * feat: Add ecs_service intent for managing containers in Amazon ECS * [S73] Feature: Per-Instance Artifactories Module (#215) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output * add database operator as per instance module * add database operator as necessary input for postgres user * add crossplane as per instance module * add crossplane as necessary input in mysql user * update the regex for crossplane * add mongodb auth operator as per instance module * add mongodb auth operator as necessary input in mongo user * update description * update output string * add database operator intent in index.json * update sample * update sample * update description mongo user * formatting changes * move values to spec and use facets as default namespace * fix display name and description in mongo user * added back inputs --------- Co-authored-by: pramodh-ayyappan <108784231+pramodh-ayyappan@users.noreply.github.com> Co-authored-by: rohit (aider) <facets.raveendran@mercedes-benz.com> Co-authored-by: pramodh-ayyappan <pramodh.ayyappan@facets.cloud> * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * [S73] Feature: Per-Instance Artifactories Module (#210) * Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit a6777ed. * Innersourcing workflows (#230) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Innersourcing workflows update (#231) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable. * Innersourcing workflows (#230) * added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * added github workflows for validate bootrapper (#245) * Github actions fixes (#249) * github actions fixes * changed the env variable name * Reapply "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214) This reverts commit 9dbcda0. * adding back removed artifactory changes * added back artifactories inputs * innersourcing sync with master * added outputs for vpc (#333) * added outputs for vpc * fixed outputs * removed outputs from intent/network (#334) * removed outputs from intent/network * added default outputs from intent/network * Revert "removed outputs from intent/network (#334)" (#348) This reverts commit 46e158b. * Revert "added outputs for vpc (#333)" (#349) This reverts commit 509287b. * added added outputs for network * added outputs to network module --------- Co-authored-by: Shashwat Pathak <shashwat.pathak@facets.cloud> Co-authored-by: pramodh-ayyappan <108784231+pramodh-ayyappan@users.noreply.github.com> Co-authored-by: Ishaan Kalra <108509616+ishaankalra@users.noreply.github.com> Co-authored-by: ishaankalra <ishaan.kalra@facets.cloud> Co-authored-by: Sanmesh Kakade <sanmesh.kakade@facets.cloud> Co-authored-by: rohit (aider) <facets.raveendran@mercedes-benz.com> Co-authored-by: pramodh-ayyappan <pramodh.ayyappan@facets.cloud>

* Add missing pattern properties * x-ui-override-disable and items of type string on all array types * Fix misc problems

This reverts commit d13f789.

This reverts commit 2bff998.

ShrinidhiFCTS23 requested review from anshulsao, ishaankalra, pramodh-ayyappan, rr0hit, unni-facets and vishnukv-facets as code owners June 3, 2025 07:00

anujhydrabadi approved these changes Jun 3, 2025

View reviewed changes

ishaankalra marked this pull request as draft June 4, 2025 06:50

pramodh-ayyappan force-pushed the develop branch from 8271b83 to 3680802 Compare June 5, 2025 10:21

mbhandari31 marked this pull request as ready for review June 5, 2025 10:49

mbhandari31 approved these changes Jun 5, 2025

View reviewed changes

ishaankalra approved these changes Jun 9, 2025

View reviewed changes

pramodh-ayyappan force-pushed the develop branch from e841913 to 52e4748 Compare June 16, 2025 13:04

ShrinidhiFCTS23 force-pushed the rm-alias-flavor branch from 1be48c5 to 2e80ea0 Compare June 17, 2025 08:50

Shashwatpathak05 and others added 14 commits June 17, 2025 18:01

if price is 0, exclude from dataset (#174)

4bec2b5

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

removed incorrect files (#176)

633c821

Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

218764d

This reverts commit a6777ed.

if price is 0, exclude from dataset (#174)

d6c50e1

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

removed incorrect files (#176)

d2d3f64

Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

ebdbcb2

This reverts commit a6777ed.

updated to work with github app

ac9e1df

(cherry picked from commit 122c9dc28b355bfe612e98f026decf2195beb507)

if price is 0, exclude from dataset (#174)

744add0

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

removed incorrect files (#176)

393144c

pramodh-ayyappan and others added 21 commits June 17, 2025 18:01

Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

603da7b

This reverts commit a6777ed.

added github workflows for validate bootrapper (#245)

c4bee31

Github actions fixes (#249)

78e0ac1

* github actions fixes * changed the env variable name

Reapply "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

55190fb

This reverts commit 9dbcda0.

adding back removed artifactory changes

ef10bdc

innersourcing sync with master

b224af7

added outputs for vpc (#333)

cb95d50

* added outputs for vpc * fixed outputs

removed outputs from intent/network (#334)

8e5c1ac

* removed outputs from intent/network * added default outputs from intent/network

Revert "removed outputs from intent/network (#334)" (#348)

7d29a54

This reverts commit 46e158b.

Revert "added outputs for vpc (#333)" (#349)

f9e2b6b

This reverts commit 509287b.

Standardize spec for json schema (#361)

d0bd4a9

* Add missing pattern properties * x-ui-override-disable and items of type string on all array types * Fix misc problems

added form support for json data

53a539a

fix in cm02

d87a6a8

Revert "fix in cm02"

a8bb3b8

This reverts commit d13f789.

Revert "added form support for json data"

d55bec1

This reverts commit 2bff998.

Remove default from namespace (release failure bug fix)

1f4eba7

pramodh-ayyappan force-pushed the develop branch from 049a1e3 to 143dd82 Compare June 17, 2025 12:31

rr0hit force-pushed the rm-alias-flavor branch from 2e80ea0 to cfe77f0 Compare June 18, 2025 04:12

Shashwatpathak05 and others added 2 commits June 18, 2025 12:07

added indexes

bcaedcd

removed alias-flavor for cluster, network and account

cac33eb

ShrinidhiFCTS23 force-pushed the rm-alias-flavor branch from cfe77f0 to cac33eb Compare June 18, 2025 06:37

pramodh-ayyappan force-pushed the develop branch from a29e116 to b4563d5 Compare June 27, 2025 06:49

ishaankalra force-pushed the develop branch from d7915e6 to c31a582 Compare July 4, 2025 07:20

pramodh-ayyappan force-pushed the develop branch 2 times, most recently from 198733a to f25c3b8 Compare July 30, 2025 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

removed alias-flavor for cluster, network and account #392

removed alias-flavor for cluster, network and account #392

Uh oh!

ShrinidhiFCTS23 commented Jun 3, 2025

Uh oh!

coderabbitai bot commented Jun 3, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

removed alias-flavor for cluster, network and account #392

Are you sure you want to change the base?

removed alias-flavor for cluster, network and account #392

Uh oh!

Conversation

ShrinidhiFCTS23 commented Jun 3, 2025

Description

Related issues

Type of change

Checklist

Testing

Reviewer instructions

Uh oh!

coderabbitai bot commented Jun 3, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)