add eks auto mode 0.3 version #332
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnukv-facets
force-pushed
the
eks_auto
branch
3 times, most recently
from
00d2ea9 to
92dbe03
Compare
…ic tag generation
…y removing the merge function and directly defining parameters.
…add missing configurations
…p3-sc" for clarity and consistency.
… and updating main.tf to include it in module inputs. This improves network configuration flexibility.
…merations for log types and reclaim policies, and implement visibility conditions for dedicated and default node pool settings. This improves user experience and flexibility in cluster management.
…e configuration options and focus on essential settings for cluster logging.
… introduce max_size_cpu and max_size_memory parameters, replacing previous desired_size, min_size, and max_size fields. Add dedicated and default node pool definitions in locals.tf and update main.tf to include modules for both node pools, enhancing cluster management and resource allocation.
…rsion' in the spec, enhancing the clarity of required fields for configuration. Additionally, add 'kubernetes_version' to the required fields under the node pool specifications for improved validation.
…treamlining the module setup and improving clarity.
…sistency in module referencing.
…roved clarity and consistency.
…new modules for improved organization and clarity. Add comprehensive configurations for managed and self-managed node groups, Fargate profiles, and IAM roles, enhancing flexibility and usability. Update user data templates for various operating systems to streamline node initialization.
…oup sizing parameters with max_size_cpu and max_size_memory. Update validation logic for improved clarity and consistency in configuration.
…s. Update EKS module to use local path for KMS module, removing version attribute for compatibility.
…patibility with local module paths.
…ools in main.tf to ensure proper resource initialization.
…pdating provider authentication references to use k8s_details for improved clarity and reliability.
…mproved flexibility in configuration.
…ions in main.tf and variables.tf.
…ion in variables.tf files.
…luster data sources and provider configurations for improved authentication and resource management.
… k8s_cluster main.tf for improved clarity and maintainability.
… and namespace handling in locals.tf for improved resource management and flexibility.
…d resource management
…ved clarity and flexibility; remove deprecated instance variable structure and add new variable definitions for better configuration management.
…id for improved consistency and accuracy in resource identification; remove unnecessary whitespace in main.tf.
…to k8s_details for improved consistency and clarity in outputs.tf and facets.yaml.
…minate the explicit provider declaration for improved clarity and maintainability.
…iguration visibility
…tputs in k8s_cluster outputs.tf for improved EKS module management and clarity.
…aml and updating legacy_outputs in outputs.tf to reference the correct IAM role and security group for improved resource management and clarity.
…and adding secret copier configuration, while enhancing legacy_outputs in outputs.tf for improved resource management and clarity.
…ule in secrets.tf for improved resource allocation and management.
… initializing output_interfaces in outputs.tf for improved clarity and maintainability.
… dedicated and default node pools, ensuring accurate resource configuration based on node pool settings.
Collaborator
|
Check if EFS driver is supported in Auto Mode, and also check if there are any other controllers missing |
pramodh-ayyappan
requested changes
May 23, 2025
| @@ -0,0 +1,319 @@ | |||
| intent: kubernetes_cluster | |||
| flavor: aws_eks | |||
Collaborator
There was a problem hiding this comment.
@rr0hit Can we have new flavor for this since users might be allowed to update to new version in the UI will become a problem if we release it as a new version instead of a new flavor
pramodh-ayyappan
requested changes
May 29, 2025
|
|
||
| module "eks" { | ||
| source = "./aws-terraform-eks" | ||
| cluster_name = "${substr(var.cluster.name, 0, 38 - 11 - 12)}-${var.cluster.clusterCode}-k8s-cluster" |
Collaborator
There was a problem hiding this comment.
cluster_name implementation should be same as 0.1 and 0.2 since we will have multi cluster setup as well
https://github.com/Facets-cloud/facets-iac/blob/de0d67aca6b3b46aad1080165c057723084a0ebe/capillary-cloud-tf/modules/3_utility/legacy_aws_eks/k8s_cluster/main.tf#L135
pramodh-ayyappan
requested changes
May 29, 2025
| alias-flavors: [ "default" ] | ||
| version: "0.3" | ||
| metadata: | ||
| name: "eks-cluster" |
| x-ui-visible-if: | ||
| field: spec.cluster.kms_keys.enable_rotation | ||
| values: [true] | ||
| required: |
Collaborator
There was a problem hiding this comment.
indentation for required block should be one level back, since required is for cluster properties not for kms property
| }) | ||
| } | ||
|
|
||
| variable "cluster" { |
| default = {} | ||
| } | ||
|
|
||
| variable "cc_metadata" { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Type of change
Checklist
developbranchTesting
Reviewer instructions