-
Notifications
You must be signed in to change notification settings - Fork 5
ota doc and legacy compat fixes #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SirRGB
wants to merge
4
commits into
FOSSonTop:master
Choose a base branch
from
SirRGB:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| order: 5 | ||
| --- | ||
|
|
||
| # Setting up ota updates | ||
|
|
||
| First we need to tell the updater where to look for the updater info. We can do that using an [overlay in the device tree](https://github.com/SirRGB/android_device_oneplus_msm8998-common/commit/fe390cf65b910c9833b7cc4fbbd1359ff5b5fb9f). Be sure to use the exact url, that only provides text and not an entire webpage. {device} resolves to the devices codename, i.e. cheeseburger for the OnePlus 5. | ||
| On lineage you can simply pick [this commit](https://github.com/amyROM/vendor_amy/commit/eb0ff17ced46d969bdc5a4e8599433d76f93f8f5) and [use sha256sum](https://github.com/amyROM/vendor_amy/commit/1938b05bf3d0d8fc6e1bfb16a6be033b6a624502#diff-91c830a3d50e97454dfe32defa90f9635bd926ad3130f2a1cdf06f52e980026fR9) instead of md5sum. | ||
| After the build you get a json file named similarly to the package name, which you can upload to the url you specified in the updater overlay after you uploaded the package and adapted the url within the ota info to reflect that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to fetch this from conda?
Does this work? https://anaconda.org/channels/main/packages/java-1.8.0-openjdk-el8-x86_64/overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds really nice, but Id rather go for something more well proven and audited, which this doesnt really imply:
Total Downloads
25
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I kind of agree... I'll see if they have a better package
Update: how about openjdk==8.0.472 from https://anaconda.org/channels/conda-forge/packages/openjdk/overview? These are zulu openJDK builds, I think, according to https://stackoverflow.com/a/72366938
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, description says it is zulu too.
Last updated in dec 2025 and 15k downloads is good ig.
We could also go the weird way and tell people to download the jdk and export some variables, which is independant of python. I do so for dockdroid and it just works. :)