Skip to content

Improve non-matching interpolation for non-affine grids.#4127

Draft
jorgensd wants to merge 3 commits intodokken/pull_back_scratch_memoryfrom
dokken/proper-non-affine-collision-detection
Draft

Improve non-matching interpolation for non-affine grids.#4127
jorgensd wants to merge 3 commits intodokken/pull_back_scratch_memoryfrom
dokken/proper-non-affine-collision-detection

Conversation

@jorgensd
Copy link
Member

For non-affine grids, the convex hull search often prove insufficient to get the correct colliding cell, for instance for non-matching interpolation (ref: https://fenicsproject.discourse.group/t/second-order-meshes-interpolation-error/19544/9?u=dokken).
This PR splits the non-affine (local) collision detection into two steps:

  1. Check if point is within convex hull of cell.
  2. If within convex hull, use the non-affine pullback to get point in reference space.

The logic for affine geometries is unchanged.
Requires #4126 as it showed up as a major performance bottleneck for this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant