SuperLU_dist solver interface #4054
Draft
+576
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Jan 28, 2026
jorgensd
reviewed
Jan 28, 2026
…enics/dolfinx into jhale/superlu-interface-deleters
jorgensd
reviewed
Jan 28, 2026
python/test/unit/la/test_superlu.py
Outdated
| L = form(L, dtype=dtype) | ||
|
|
||
| u_bc = Function(V, dtype=dtype) | ||
| u_bc.interpolate(lambda x: x[1]**3) |
Member
There was a problem hiding this comment.
Wouldn't it be better to define
def u_ex(x):
return x[1]**3
f = -div(grad(x))
u_bc.interpolate(u_ex)
so that if we ever change u_ex it is reflected everywhere at once.
…dolfinx into jhale/superlu-interface-deleters
| declare_superlu_solver<double>(m, "float64"); | ||
| declare_superlu_solver<float>(m, "float32"); | ||
| declare_superlu_solver<std::complex<double>>(m, "complex128"); | ||
| #endif // HAS_SUPERLU_DIST |
Contributor
There was a problem hiding this comment.
I wonder if we should just put the #ifdef inside declare_superlu_solver() - it gets called, but does nothing - just looks neater with fewer #ifdefs.
Member
Author
There was a problem hiding this comment.
I don't mind the slight overuse of template ifs as long as they aren't nested.
|
|
||
| uh = Function(V, dtype=dtype) | ||
| solver = superlu_solver(A) | ||
| solver.solve(b._cpp_object, uh.x._cpp_object) |
Contributor
There was a problem hiding this comment.
Isn't this supposed to work without ._cpp_object?
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
| stype = _cpp.la.SuperLUSolver_complex128 | ||
| else: | ||
| raise NotImplementedError(f"Type {dtype} not supported.") | ||
| return stype(A._cpp_object) |
Contributor
There was a problem hiding this comment.
I think this should be wrapped in SuperLUSolver above?
…enics/dolfinx into jhale/superlu-interface-deleters
jorgensd
reviewed
Jan 28, 2026
Comment on lines
+44
to
+52
| x = SpatialCoordinate(mesh) | ||
| u_exact = x[1] ** 3 | ||
| f = -div(grad(u_exact)) | ||
|
|
||
| L = inner(f, v) * dx | ||
| L = form(L, dtype=dtype) | ||
|
|
||
| u_bc = Function(V, dtype=dtype) | ||
| u_bc.interpolate(lambda x: x[1] ** 3) |
Member
There was a problem hiding this comment.
Suggested change
| x = SpatialCoordinate(mesh) | |
| u_exact = x[1] ** 3 | |
| f = -div(grad(u_exact)) | |
| L = inner(f, v) * dx | |
| L = form(L, dtype=dtype) | |
| u_bc = Function(V, dtype=dtype) | |
| u_bc.interpolate(lambda x: x[1] ** 3) | |
| def u_ex(x): | |
| return x[1] ** 3 | |
| x = SpatialCoordinate(mesh) | |
| f = -div(grad(u_ex(x))) | |
| L = inner(f, v) * dx | |
| L = form(L, dtype=dtype) | |
| u_bc = Function(V, dtype=dtype) | |
| u_bc.interpolate(u_ex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint work with @chrisrichardson
This adds an optional SuperLU_dist interface to DOLFINx for solving systems constructed using MatrixCSR. The purpose of this is to provide a reasonable MPI-capable LU solver for DOLFINx builds without PETSc on all platforms.
The implementation is pretty light, and does not include SuperLU headers into our headers.
TODO:
In future PRs:
dolfinx.fem.LinearProblemclass for beginners.dolfinx.fem.NonlinearProblemclass for beginners.