Bugfix rotbd #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. You wrote a regtest that checks that behavior is as expected for ww3_multi with switch RTD. Are we missing any checks, e.g. that a ww3_multi model run with a regular pole is able to output boundary conditions to a destination grid that is rotated?
Author
There was a problem hiding this comment. If ww3_multi writes boundary files not identical to the output with ww3_shel, that would be a separate issue. There was a problem hiding this comment. CHA: Missing to test that if outer domain has incoming boundary conditions (nest.ww3 defined) it is correctly rotated to rank 1 grid and that BCTURN is correctly set to false afterwards when nesting between outer and fine grid. That would test both cases of BCTURN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| ############################################################################# | ||
| # # | ||
| # Case switch RTD # | ||
| # # | ||
| # mww3_test_02 : Test for static nesting (propagation only) # | ||
| # Single nest basic test. # | ||
| # # | ||
| # The test case here is for spherical (longitude,latitude) grids with a # | ||
| # (common) rotated pole # | ||
| # The test case is adopted from mww3_test_02 with inputs marked 'rtd' # | ||
| # The grid set grdset_r is a spherical approximation to Cartesian grdset_b # | ||
| # The script run_cmake_test is run with option -g rtd # | ||
| # # | ||
| # * ww3_grid_rtd_outer.inp : (only outer grid) # | ||
| # + Spatial grid: 43 x 43 rectilinear spherical grid # | ||
| # - dx = 0.225 deg, dy = 0.225 deg # | ||
| # - Xrange = -5.625:3.825 deg, Yrange = -5.625:3.825 deg # | ||
| # - Grid north pole at lon, lat = -90., 0. # | ||
| # + Spectral grid: ntheta = 24, nf = 25, f1 = 0.04177, fgamma = 1.1 # | ||
| # # | ||
| # * ww3_grid_rtd_fine.inp : (double resolution inner grid) # | ||
| # + Spatial grid: 25 x 25 rectilinear spherical grid # | ||
| # - dx = 0.1125 deg, dy = 0.1125 deg # | ||
| # - Xrange = 0:2.7 deg, Yrange = 0:2.7 deg # | ||
| # - Grid north pole at lon, lat = -90., 0. # | ||
| # + Spectral grid: ntheta = 24, nf = 25, f1 = 0.04177, fgamma = 1.1 # | ||
| # # | ||
| # * Grid set : # | ||
| # + grdset_r: outer + fine # | ||
| # # | ||
| # * Switch: # | ||
| # + switch_PR3_UQ_MPI_RTD # | ||
| # # | ||
| # Example run_test command: # | ||
| # ./bin/run_cmake_test -N -g rtd -m grdset_r -n 3 -p mpirun \ # | ||
| # -s PR3_UQ_MPI_RTD -w work_bp_PR3_MPI_RTD ../model mww3_test_02 # | ||
|
Comment on lines
+35
to
+36
There was a problem hiding this comment. I am able to run the regtest but not with the -N (use .mnl files) flag. It works with .inp files. The output looks strange, however, and not as presented in your issue post on NOAAs GitHub account. Are you able to run the regtest with .nml files successfully? |
||
| # # | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| MODEL: outer fine | ||
| INPUT: | ||
| POINT: outer fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| &OUTS E3D=1, TH1MF=1, STH1MF=1, TH2MF=1, STH2MF=1 / | ||
| &PRO2 DTIME = 0. / | ||
| &PRO3 WDTHCG = 0., WDTHTH = 0. / | ||
|
There was a problem hiding this comment. Are settings for both PRO2 and PRO3 mentioned as the regtest can be run with different switches that both involve PRO2 and PRO3? The info_fcoo only mentions switch_PR3_UQ_MPI_RTD.
Author
There was a problem hiding this comment. This may be a reason, but I just copied the contents of namelisis_fine.nml without thinking about it. |
||
| &ROTD PLAT = 0.0 PLON = -90.0, UNROT = .FALSE. / | ||
| END OF NAMELISTS | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| &OUTS E3D=1, TH1MF=1, STH1MF=1, TH2MF=1, STH2MF=1 / | ||
| &PRO2 DTIME = 0. / | ||
|
|
||
| &PRO3 WDTHCG = 0., WDTHTH = 0. / | ||
| &ROTD PLAT = 0.0 PLON = -90.0, UNROT = .FALSE. / | ||
| END OF NAMELISTS | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 1.35 1.35 'point_A' | ||
|
There was a problem hiding this comment. Please remind me; point output coordinates are defined in the rotated grid, correct? So this coordinate is within the fine grid?
Author
There was a problem hiding this comment. I actually forgot the answer to this. I think the answer is given in the User manual, or check the points specified for the FCOO GRL9 grid. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| NOGRB RTD DIST MPI PR3 UQ FLX2 LN0 ST0 NL0 BT0 DB0 TR0 BS0 IC0 IS0 REF0 WNT1 WNX1 CRT1 CRX1 O0 O1 O2 O3 O4 O5 O6 O7 O10 O11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| $ WAVEWATCH III Grid preprocessor input file | ||
| $ ------------------------------------------ | ||
| 'Fine (12.5km) inner nest ' | ||
| $ | ||
| 1.1 0.04177 25 24 0. | ||
| $ | ||
| F T T F F F | ||
| 450. 450. 450. 15. | ||
| $ | ||
| &OUTS E3D=1, TH1MF=1, STH1MF=1, TH2MF=1, STH2MF=1 / | ||
| &PRO2 DTIME = 0. / | ||
| $ &PRO2 DTIME = 21600. / | ||
|
MadsBruunPoulsen marked this conversation as resolved.
|
||
| &PRO3 WDTHCG = 0., WDTHTH = 0. / | ||
| &ROTD PLAT = 0.0 PLON = -90.0, UNROT = .FALSE. / | ||
|
MadsBruunPoulsen marked this conversation as resolved.
|
||
| END OF NAMELISTS | ||
|
MadsBruunPoulsen marked this conversation as resolved.
|
||
| $ | ||
| 'RECT' T 'NONE' | ||
| 25 25 | ||
| 0.1125 0.1125 1. | ||
| 0.0 0.0 1. | ||
| $ | ||
| -0.1 0.25 10 -1000. 4 1 '(....)' 'UNIT' 'input' | ||
| $ | ||
| 625*1 | ||
| $ | ||
| 10 1 1 '(....)' 'PART' 'mapsta.inp' | ||
| $ | ||
| 1 1 T | ||
| 1 25 T | ||
| 25 25 T | ||
| 25 1 T | ||
| 1 1 T | ||
| 0 0 F | ||
| $ | ||
| 0 0 F | ||
| 0 0 | ||
| $ | ||
| 0. 0. 0. 0. 0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| ! -------------------------------------------------------------------- ! | ||
| ! WAVEWATCH III - ww3_grid.nml - Grid pre-processing ! | ||
| ! -------------------------------------------------------------------- ! | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the spectrum parameterization via SPECTRUM_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &SPECTRUM_NML | ||
| SPECTRUM%XFR = 1.1 | ||
| SPECTRUM%FREQ1 = 0.04177 | ||
| SPECTRUM%NK = 25 | ||
| SPECTRUM%NTH = 24 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the run parameterization via RUN_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &RUN_NML | ||
| RUN%FLCX = T | ||
| RUN%FLCY = T | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the timesteps parameterization via TIMESTEPS_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &TIMESTEPS_NML | ||
| TIMESTEPS%DTMAX = 450. | ||
| TIMESTEPS%DTXY = 450. | ||
| TIMESTEPS%DTKTH = 450. | ||
| TIMESTEPS%DTMIN = 15. | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the grid to preprocess via GRID_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &GRID_NML | ||
| GRID%NAME = 'Fine (12.5km) inner nest' | ||
| GRID%NML = '../input/namelists_rtd_fine.nml' | ||
| GRID%TYPE = 'RECT' | ||
| GRID%COORD = 'SPHE' | ||
| GRID%CLOS = 'NONE' | ||
| GRID%ZLIM = -0.1 | ||
| GRID%DMIN = 0.25 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the rectilinear grid type via RECT_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &RECT_NML | ||
| RECT%NX = 25 | ||
| RECT%NY = 25 | ||
| RECT%SX = 0.1125 ! from SX_cart=12.5E3 m to SX_cart/111111.111 deg | ||
| RECT%SY = 0.1125 | ||
| RECT%X0 = 0.0 ! from 600.0E3 | ||
| RECT%Y0 = 0.0 ! from 600.0E3 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the depth to preprocess via DEPTH_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &DEPTH_NML | ||
| DEPTH%SF = -1000. | ||
| DEPTH%FILENAME = '../input/fine.depth' | ||
| DEPTH%IDLA = 4 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the input boundary points via INBND_COUNT_NML and | ||
| ! INBND_POINT_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &INBND_COUNT_NML | ||
| INBND_COUNT%N_POINT = 5 | ||
| / | ||
|
|
||
| &INBND_POINT_NML | ||
| INBND_POINT(1) = 1 1 T | ||
| INBND_POINT(2) = 1 25 T | ||
| INBND_POINT(3) = 25 25 T | ||
| INBND_POINT(4) = 25 1 T | ||
| INBND_POINT(5) = 1 1 T | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! WAVEWATCH III - end of namelist ! | ||
| ! -------------------------------------------------------------------- ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| $ WAVEWATCH III Grid preprocessor input file | ||
| $ ------------------------------------------ | ||
| 'The outer grid @ 0.225 deg ' | ||
| $ | ||
| 1.1 0.04177 25 24 0. | ||
| $ | ||
| F T T F F F | ||
| 900. 900. 900. 15. | ||
| $ | ||
| &OUTS E3D=1, TH1MF=1, STH1MF=1, TH2MF=1, STH2MF=1 / | ||
| &PRO2 DTIME = 0. / | ||
| $ &PRO2 DTIME = 21600. / | ||
| &PRO3 WDTHCG = 0., WDTHTH = 0. / | ||
| &ROTD PLAT = 0.0 PLON = -90.0, UNROT = .FALSE. / | ||
|
MadsBruunPoulsen marked this conversation as resolved.
|
||
| END OF NAMELISTS | ||
| $ | ||
| 'RECT' T 'NONE' | ||
| 43 43 | ||
| 0.225 0.225 1. | ||
| -5.625 -5.625 1. | ||
| $ | ||
| -0.1 0.25 10 -1000. 4 1 '(....)' 'UNIT' 'input' | ||
| $ | ||
| 1849*1 | ||
| $ | ||
| 10 1 1 '(....)' 'PART' 'mapsta.inp' | ||
| $ | ||
| 0 0 F | ||
| 0 0 F | ||
| 0 0 | ||
| $ | ||
| 0. 0. 0. 0. 0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| ! -------------------------------------------------------------------- ! | ||
| ! WAVEWATCH III - ww3_grid.nml - Grid pre-processing ! | ||
| ! -------------------------------------------------------------------- ! | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the spectrum parameterization via SPECTRUM_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &SPECTRUM_NML | ||
| SPECTRUM%XFR = 1.1 | ||
| SPECTRUM%FREQ1 = 0.04177 | ||
| SPECTRUM%NK = 25 | ||
| SPECTRUM%NTH = 24 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the run parameterization via RUN_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &RUN_NML | ||
| RUN%FLCX = T | ||
| RUN%FLCY = T | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the timesteps parameterization via TIMESTEPS_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &TIMESTEPS_NML | ||
| TIMESTEPS%DTMAX = 900. | ||
| TIMESTEPS%DTXY = 900. | ||
| TIMESTEPS%DTKTH = 900. | ||
| TIMESTEPS%DTMIN = 15. | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the grid to preprocess via GRID_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &GRID_NML | ||
| GRID%NAME = 'The outer grid @ 25 km' | ||
| GRID%NML = '../input/namelists_rtd_outer.nml' | ||
| GRID%TYPE = 'RECT' | ||
| GRID%COORD = 'SPHE' | ||
| GRID%CLOS = 'NONE' | ||
| GRID%ZLIM = -0.1 | ||
| GRID%DMIN = 0.25 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the rectilinear grid type via RECT_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &RECT_NML | ||
| RECT%NX = 43 | ||
| RECT%NY = 43 | ||
| RECT%SX = 0.225 ! from SX_cart=25.E3 m to SX_cart/111111.111 deg | ||
| RECT%SY = 0.225 | ||
| RECT%X0 = -5.625 ! from -25.E3 or -1.*SX to -25*SX | ||
| RECT%Y0 = -5.625 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! Define the depth to preprocess via DEPTH_NML namelist | ||
| ! -------------------------------------------------------------------- ! | ||
| &DEPTH_NML | ||
| DEPTH%SF = -1000. | ||
| DEPTH%FILENAME = '../input/outer.depth' | ||
| DEPTH%IDLA = 4 | ||
| / | ||
|
|
||
| ! -------------------------------------------------------------------- ! | ||
| ! WAVEWATCH III - end of namelist ! | ||
| ! -------------------------------------------------------------------- ! |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.