feat(170): 민감정보 마스킹#236
Draft
GentleDot wants to merge 1 commit into
Draft
Conversation
- maskIt 라이브러리 사용 - 카드 번호 커스텀 설정에 버그가 있음을 확인 ㅠㅠㅠㅠㅠㅠㅠㅠ - userPaymentMethodException 신설
GentleDot
requested review from
a team,
InvestLee,
Raemerrr and
devch37
and removed request for
a team
devch37
approved these changes
Feb 17, 2025
Contributor
devch37
left a comment
devch37
left a comment
There was a problem hiding this comment.
오 상일님의 오픈 소스라니 멋있습니다 ㅎㅎ ! 고생하셨습니다 !
GentleDot
commented
Feb 17, 2025
| val masked = cardMaskingModule.mask(cardNumber) | ||
| if (split.size != 4) throw UserPaymentMethodException.InvalidCardNumberException(masked) | ||
| val firstNumberPart = split[0] | ||
| return """$firstNumberPart${masked.substring(4)}""" |
Contributor
Author
There was a problem hiding this comment.
차후에 maskIt version up 해서
1-2-3-4 <- 중에 원하는 구간을 마스킹하도록 변경해보겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
PR 유형