Skip to content

Conversation

@gqcorneby
Copy link
Contributor

@gqcorneby gqcorneby commented Sep 24, 2025

📌 References

📝 Implementation

  • generate 2.42 schemas
  • 2.42 doesn't have AttributeValue model which results to props that use the model as unknown
    • add prop in interfaceFromClass

Updates in projects that will use 2.42 schema

  1. User
    • removed userCredentials, twoFactorEnabled
    • new props: verifiedEmail, emailVerificationToken
  2. /metadata filters using identifiable:in results to an error. We would need to split these queries.
  3. attributeValue filter error
    Error: Unknown path property: attributeValues.value and Unknown path property: attributeValues.attribute.id
    for filters like this:
filter: attributeValues.attribute.id:eq:<attributeId>
filter: attributeValues.value:eq:true

update to

<attributeId>:!null
<attributeId>:eq:true
  1. double headers. Fix: conditionally render header
    EyeSeeTea/dhis_tally_sheets@2d9716b

📹 Screenshots/Screen capture

🔥 Testing

yarn install
yarn build

On another app (assuming app is in the same directory as d2-api):

 yarn add ../d2-api/build/

@bundlemon
Copy link

bundlemon bot commented Sep 24, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
267.98KB (+66.19KB +32.8%) +20%

Final result: ❌

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When used in real apps, we may some things to fix/enhance — we’ll open PRs for those. Approving.

@MiquelAdell MiquelAdell merged commit efa4c46 into master Sep 26, 2025
3 of 6 checks passed
@MiquelAdell MiquelAdell deleted the feature/2.42-schema branch September 26, 2025 06:26
@gqcorneby gqcorneby mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants