fix: No date values added to database for Datacite records with empty date array#5
Open
aaronm-2112 wants to merge 3 commits into
Open
fix: No date values added to database for Datacite records with empty date array#5aaronm-2112 wants to merge 3 commits into
aaronm-2112 wants to merge 3 commits into
Conversation
aaronm-2112
changed the title
aaronm-2112
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datacite date arrays can be empty. When this happens we fall back to created and registered dates. Registered is preferred. NOTE: the registered date is the date the DOI is resolvable not necessarily when the dataset was first published.
The date values for all non-datacite entries remain the same after a test run. In the same test run, the date values for datacite values are updated to use registered when the date array is empty - none fell back so far that they need to use created date.