Skip to content

Remove legacy migration repair paths#2420

Open
chubes4 wants to merge 1 commit into
mainfrom
fix/legacy-migration-first-cut-2411-2418
Open

Remove legacy migration repair paths#2420
chubes4 wants to merge 1 commit into
mainfrom
fix/legacy-migration-first-cut-2411-2418

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 31, 2026

Summary

  • Removes the flows migrate-legacy-handler-shape WP-CLI repair command and its one-shot migrator/test so stored workflow specs stay canonical-only for 1.0.
  • Drops recurring task-scoped hook discovery/cleanup and keeps recurring schedule reconciliation on canonical schedule-scoped hooks only.
  • Removes the frontend fallback for the old bare-array flow memory-files response shape and updates docs to match the remaining 1.0 surface.

Verification

  • php -l inc/Cli/Commands/Flows/FlowsCommand.php && php -l inc/Engine/AI/System/SystemAgentServiceProvider.php && php -l inc/Engine/Tasks/RecurringScheduleRegistry.php && php tests/recurring-schedule-registry-contract-smoke.php && php tests/workflow-spec-contract-smoke.php && php tests/system-task-workflow-validation-smoke.php
  • vendor/bin/phpcs inc/Cli/Commands/Flows/FlowsCommand.php inc/Engine/AI/System/SystemAgentServiceProvider.php inc/Engine/Tasks/RecurringScheduleRegistry.php tests/recurring-schedule-registry-contract-smoke.php
  • homeboy lint --path . --extension wordpress --changed-only
  • homeboy test --path . --extension wordpress --changed-since HEAD
  • git diff --check

Notes

  • Full homeboy lint --path . --extension wordpress was also run after the first edit. It reported two unrelated existing findings in inc/Engine/AI/ConversationManager.php and inc/Core/FilesRepository/MediaValidator.php, plus one local formatting issue that was fixed. The changed-only lint is green with no baseline drift.

Follow-up

  • Finish the final pre-1.0 migration nuke by reviewing remaining deploy-time schema ensures under inc/migrations/ and repository-level migrate_* methods that still have concrete table/column responsibilities.
  • Audit remaining compatibility wording and non-runtime docs for public extension hooks that should either become canonical 1.0 contracts or be removed.
  • Coordinate any result/tool-contract compatibility removals with the active result/tool-contract lane to avoid conflicts.

Closes #2411.
Refs #2418.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Inventorying legacy/backcompat paths, drafting the code removals, updating tests/docs, and running verification. Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 31, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since 424a39a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26714809188

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since 424a39a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26714809188

Audit

audit — passed

  • audit — 33 finding(s)
  • Total: 33 finding(s)

Deep dive: homeboy audit data-machine --changed-since 424a39a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26714809188
Tooling versions
  • Homeboy CLI: homeboy 0.213.4+8e7a1ed7
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 06cc67ae
  • Action: unknown@unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove legacy handler and workflow shapes from runtime paths

1 participant