style: clear phpcs lint debt (release preflight)#2384
Merged
Conversation
Apply phpcbf auto-fixes for the two fixable statement-alignment findings tracked in #2369: - inc/Cli/Commands/Flows/QueueCommand.php:400 - inc/Engine/AI/conversation-loop.php:316 Both are Generic.Formatting.MultipleStatementAlignment.IncorrectWarning (extra space before =). Formatting only, zero logic changes. The remaining Yoda-condition finding (ConversationManager.php:365) is not auto-fixable and is left for manual review per #2369. Refs #2369
Member
Author
|
<@532385681268408341> ready for review — phpcbf auto-fixes for the 2 statement-alignment findings in #2369. Formatting only. The remaining Yoda-condition finding (ConversationManager.php:365) is documented in the PR body as needing a manual rewrite (not included here, per the auto-fix-only scope). |
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the auto-fixable PHPCS lint debt tracked in #2369 so the release preflight (
homeboy lint) stops inheriting red checks on otherwise-clean PRs. Formatting only — zero logic changes.Before / after
homeboy lintonmainreported 3 findings:inc/Engine/AI/ConversationManager.php:365WordPress.PHP.YodaConditions.NotYodainc/Cli/Commands/Flows/QueueCommand.php:400Generic.Formatting.MultipleStatementAlignment.IncorrectWarninginc/Engine/AI/conversation-loop.php:316Generic.Formatting.MultipleStatementAlignment.IncorrectWarningAfter
phpcbf(WordPress-Extra ruleset, the same standard homeboy runs):phpcscleanly with 0 findings.The diff (formatting-only confirmation)
Both changes remove a single extra space before
=in a statement-alignment block. No operators, operands, or comparison order changed:Verified via
git diff: 2 files changed, 2 insertions(+), 2 deletions(-) — pure whitespace.Remaining finding — needs manual review (not in this PR)
inc/Engine/AI/ConversationManager.php:365—WordPress.PHP.YodaConditions.NotYoda(error, not phpcbf-fixable):This requires a manual Yoda-condition rewrite (reorder operands so the variable is on the right). It is semantically safe but is an operand-order change rather than a pure-whitespace auto-fix, so per the formatting-only scope of this PR it is left for a follow-up / reviewer decision. Until it's addressed,
homeboy lintwill still flag this oneerror.Refs #2369