Skip to content

style: clear phpcs lint debt (release preflight)#2384

Merged
chubes4 merged 1 commit into
mainfrom
lint-phpcbf-autofix
May 30, 2026
Merged

style: clear phpcs lint debt (release preflight)#2384
chubes4 merged 1 commit into
mainfrom
lint-phpcbf-autofix

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 30, 2026

Summary

Clears the auto-fixable PHPCS lint debt tracked in #2369 so the release preflight (homeboy lint) stops inheriting red checks on otherwise-clean PRs. Formatting only — zero logic changes.

Before / after

homeboy lint on main reported 3 findings:

# File:Line Code Severity Auto-fixable
1 inc/Engine/AI/ConversationManager.php:365 WordPress.PHP.YodaConditions.NotYoda error ❌ no
2 inc/Cli/Commands/Flows/QueueCommand.php:400 Generic.Formatting.MultipleStatementAlignment.IncorrectWarning warning ✅ yes
3 inc/Engine/AI/conversation-loop.php:316 Generic.Formatting.MultipleStatementAlignment.IncorrectWarning warning ✅ yes

After phpcbf (WordPress-Extra ruleset, the same standard homeboy runs):

The diff (formatting-only confirmation)

Both changes remove a single extra space before = in a statement-alignment block. No operators, operands, or comparison order changed:

- $step_type  = $this->getStepType( $flow_id, $flow_step_id );
+ $step_type = $this->getStepType( $flow_id, $flow_step_id );
- $datamachine_metadata     = array(
+ $datamachine_metadata = array(

Verified via git diff: 2 files changed, 2 insertions(+), 2 deletions(-) — pure whitespace.

Remaining finding — needs manual review (not in this PR)

inc/Engine/AI/ConversationManager.php:365WordPress.PHP.YodaConditions.NotYoda (error, not phpcbf-fixable):

if ( $tool_name !== ( $message['payload']['tool_name'] ?? null ) ) {

This requires a manual Yoda-condition rewrite (reorder operands so the variable is on the right). It is semantically safe but is an operand-order change rather than a pure-whitespace auto-fix, so per the formatting-only scope of this PR it is left for a follow-up / reviewer decision. Until it's addressed, homeboy lint will still flag this one error.

Refs #2369

Apply phpcbf auto-fixes for the two fixable statement-alignment findings
tracked in #2369:

- inc/Cli/Commands/Flows/QueueCommand.php:400
- inc/Engine/AI/conversation-loop.php:316

Both are Generic.Formatting.MultipleStatementAlignment.IncorrectWarning
(extra space before =). Formatting only, zero logic changes.

The remaining Yoda-condition finding (ConversationManager.php:365) is not
auto-fixable and is left for manual review per #2369.

Refs #2369
@chubes4
Copy link
Copy Markdown
Member Author

chubes4 commented May 30, 2026

<@532385681268408341> ready for review — phpcbf auto-fixes for the 2 statement-alignment findings in #2369. Formatting only. The remaining Yoda-condition finding (ConversationManager.php:365) is documented in the PR body as needing a manual rewrite (not included here, per the auto-fix-only scope).

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 30, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since b95cb35

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26697289191

Test

test — passed

ℹ️ No impacted tests found for --changed-since b95cb35
ℹ️ Run full suite if needed: homeboy test data-machine
Deep dive: homeboy test data-machine --changed-since b95cb35

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26697289191

Audit

audit — passed

  • intra-method-duplication — 9 finding(s)
  • requested_detectors — 9 finding(s)
  • dead_code — 4 finding(s)
  • dead_guard — 3 finding(s)
  • structural — 2 finding(s)
  • Directives — 1 finding(s)
  • Retention — 1 finding(s)
  • Total: 29 finding(s)

Deep dive: homeboy audit data-machine --changed-since b95cb35

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26697289191
Tooling versions
  • Homeboy CLI: homeboy 0.211.0+1bb0bc11
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 579d5b9d
  • Action: unknown@unknown

@chubes4 chubes4 merged commit a4a3398 into main May 30, 2026
5 checks passed
@chubes4 chubes4 deleted the lint-phpcbf-autofix branch May 30, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant