Skip to content

docs: de-vendor core examples (layer purity)#2380

Merged
chubes4 merged 1 commit into
mainfrom
remove-saraichinwag-examples
May 30, 2026
Merged

docs: de-vendor core examples (layer purity)#2380
chubes4 merged 1 commit into
mainfrom
remove-saraichinwag-examples

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 30, 2026

Summary

Fixes #2375 — Data Machine core (generic layer) hardcoded saraichinwag.com as the worked example in docblocks and CLI help. RULES.md layer purity counts examples as violations: generic core must not name specific sites.

Replaced all saraichinwag.com occurrences with example.com in:

  • inc/Core/Auth/AgentAuthorize.php — redirect-URI validation docblocks (~L412, L471-473)
  • inc/Cli/Commands/AgentsCommand.php:996 — CLI ## EXAMPLES help text

Scope

  • Docs/comments/help-text ONLY. No runtime logic changed — the redirect validation derives allowed hosts from network_home_url() and was already correct.

Verification

$ grep -ri saraichinwag inc/
(zero matches)

mention @Chubes — ready for review.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 30, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since ded71d3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26693707446

Test

test — passed

ℹ️ No impacted tests found for --changed-since ded71d3
ℹ️ Run full suite if needed: homeboy test data-machine
Deep dive: homeboy test data-machine --changed-since ded71d3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26693707446

Audit

audit — passed

  • requested_detectors — 14 finding(s)
  • intra-method-duplication — 8 finding(s)
  • dead_code — 6 finding(s)
  • Directives — 1 finding(s)
  • Retention — 1 finding(s)
  • structural — 1 finding(s)
  • Total: 31 finding(s)

Deep dive: homeboy audit data-machine --changed-since ded71d3

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26693707446
Tooling versions
  • Homeboy CLI: homeboy 0.210.0+26874a18
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 67347826
  • Action: unknown@unknown

@chubes4 chubes4 merged commit b95cb35 into main May 30, 2026
5 checks passed
@chubes4 chubes4 deleted the remove-saraichinwag-examples branch May 30, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LAYER-PURITY (doc): saraichinwag.com hardcoded in DM core docblocks/CLI examples

1 participant