Skip to content

feat: bump default Database engine version to Postgres 18 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droguljic wants to merge 1 commit into
base: docs/v2-update
Choose a base branch
from
Open

feat: bump default Database engine version to Postgres 18 #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/database/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const ssmHostId = ssmConnect.ec2.id;
## Implementation notes

- The primary and replica components are PostgreSQL-only (`engine: 'postgres'`).
- `Database` merges caller input with defaults of engine version `17.2`, instance class `db.t4g.micro`, `allocatedStorage: 20`, `maxAllocatedStorage: 100`, `multiAz: false`, `applyImmediately: false`, `skipFinalSnapshot: false`, `allowMajorVersionUpgrade: false`, `autoMinorVersionUpgrade: true`, and monitoring disabled.
- `Database` merges caller input with defaults of engine version `18`, instance class `db.t4g.micro`, `allocatedStorage: 20`, `maxAllocatedStorage: 100`, `multiAz: false`, `applyImmediately: false`, `skipFinalSnapshot: false`, `allowMajorVersionUpgrade: false`, `autoMinorVersionUpgrade: true`, and monitoring disabled.
- The primary subnet group always uses `vpc.isolatedSubnetIds`, and the database is always created with `publiclyAccessible: false`.
- The database security group allows TCP/5432 from the VPC CIDR block.
- The primary password is always managed through a nested `Password` component. If you omit `password`, that nested component generates a random password and stores it in Secrets Manager.
Expand Down Expand Up @@ -107,7 +107,7 @@ Direct constructor input: `args: Database.Args`
| `dbName` | `pulumi.Input<string>` | No | none | Database name for the primary instance. |
| `username` | `pulumi.Input<string>` | No | none | Master username for the primary instance. |
| `password` | `pulumi.Input<string>` | No | generated by `Password` | If omitted, a nested `Password` component generates and stores the secret. |
| `engineVersion` | `pulumi.Input<string>` | No | `'17.2'` | PostgreSQL engine version. |
| `engineVersion` | `pulumi.Input<string>` | No | `'18'` | PostgreSQL engine version. |
| `multiAz` | `pulumi.Input<boolean>` | No | `false` | Multi-AZ toggle for the primary instance. |
| `instanceClass` | `pulumi.Input<string>` | No | `'db.t4g.micro'` | Primary instance class. |
| `allocatedStorage` | `pulumi.Input<number>` | No | `20` | Initial storage in GiB. |
Expand Down Expand Up @@ -292,7 +292,7 @@ Direct constructor input: `args: DatabaseReplica.Args`
| `dbSubnetGroup` | `aws.rds.SubnetGroup` | No | none | Optional subnet group override. |
| `monitoringRole` | `aws.iam.Role` | No | none | Enables enhanced monitoring and Performance Insights when provided. |
| `parameterGroupName` | `pulumi.Input<string>` | No | none | Replica DB parameter group. |
| `engineVersion` | `pulumi.Input<string>` | No | `'17.2'` | PostgreSQL engine version. |
| `engineVersion` | `pulumi.Input<string>` | No | `'18'` | PostgreSQL engine version. |
| `multiAz` | `pulumi.Input<boolean>` | No | `false` | Multi-AZ toggle. |
| `instanceClass` | `pulumi.Input<string>` | No | `'db.t4g.micro'` | Replica instance class. |
| `allocatedStorage` | `pulumi.Input<number>` | No | `20` | Initial storage in GiB. |
Expand Down
2 changes: 1 addition & 1 deletion src/components/database/database-replica.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const defaults = {
instanceClass: 'db.t4g.micro',
allowMajorVersionUpgrade: false,
autoMinorVersionUpgrade: true,
engineVersion: '17.2',
engineVersion: '18',
};

export class DatabaseReplica extends pulumi.ComponentResource {
Expand Down
2 changes: 1 addition & 1 deletion src/components/database/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const defaults = {
enableMonitoring: false,
allowMajorVersionUpgrade: false,
autoMinorVersionUpgrade: true,
engineVersion: '17.2',
engineVersion: '18',
};

export class Database extends pulumi.ComponentResource {
Expand Down
2 changes: 1 addition & 1 deletion tests/database/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ describe('Database component deployment', () => {
performanceInsightsEnabled: false,
allowMajorVersionUpgrade: false,
autoMinorVersionUpgrade: true,
engineVersion: '17.2',
engineVersion: '18',
engine: 'postgres',
storageEncrypted: true,
publiclyAccessible: false,
Expand Down
2 changes: 1 addition & 1 deletion tests/database/infrastructure/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const kms = new aws.kms.Key(
const paramGroup = new aws.rds.ParameterGroup(
`${config.appName}-parameter-group`,
{
family: 'postgres17',
family: 'postgres18',
tags: config.tags,
},
{ parent },
Expand Down
2 changes: 1 addition & 1 deletion tests/database/replica-db.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function testReplicaDb(ctx: DatabaseTestContext) {
performanceInsightsEnabled: false,
allowMajorVersionUpgrade: false,
autoMinorVersionUpgrade: true,
engineVersion: '17.2',
engineVersion: '18',
engine: 'postgres',
storageEncrypted: true,
publiclyAccessible: false,
Expand Down