Skip to content

refactor: remove unused UpstashRedis default dbName #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droguljic wants to merge 1 commit into
base: docs/v2-update
Choose a base branch
from
+1 −3
Open

refactor: remove unused UpstashRedis default dbName #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/redis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export const passwordSecretArn = redis.password.secret.arn;
- `ElastiCacheRedis` always creates a VPC-bound, single-node Redis `aws.elasticache.Cluster` with `numCacheNodes: 1` and port `6379`; it does not create a replication group.
- The ElastiCache subnet group is built from `vpc.isolatedSubnetIds`, and the Redis security group allows TCP/6379 ingress from the VPC CIDR block.
- `ElastiCacheRedis` does not configure transit encryption, auth tokens, automatic failover, replication groups, backups, or multi-AZ failover.
- `UpstashRedis.Args.dbName` is currently required for TypeScript callers. The implementation still computes a fallback database name of `${project}-${stack}` before merging caller input, but callers should provide `dbName` until the public type is relaxed.
- `UpstashRedis` merges internal defaults of `region: 'global'` and `primaryRegion: 'us-east-1'` before creating the database.
- `UpstashRedis` always sets `eviction: true` and `tls: true` on the Upstash database.
- `UpstashRedis` creates a nested `Password` component from `instance.password`, so the Upstash password is copied into AWS Secrets Manager.
Expand Down
3 changes: 1 addition & 2 deletions src/components/redis/upstash-redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export class UpstashRedis extends pulumi.ComponentResource {
},
);

const dbName = `${pulumi.getProject()}-${pulumi.getStack()}`;
const argsWithDefaults = mergeWithDefaults({ ...defaults, dbName }, args);
const argsWithDefaults = mergeWithDefaults(defaults, args);

this.name = name;
this.instance = new upstash.RedisDatabase(
Expand Down