Skip to content

docs: document v2 components#212

Open
droguljic wants to merge 1 commit into
masterfrom
docs/v2-update
Open

docs: document v2 components#212
droguljic wants to merge 1 commit into
masterfrom
docs/v2-update

Conversation

@droguljic
Copy link
Copy Markdown
Contributor

Documentation for v2, generated with the help of AI. Component specific documentation is moved into their respective folders, main README.md only references it.
The examples folder is for now removed and replaced partially by the in documentation examples.

Documentation for v2, generated with the help of AI.
Component specific documentation is moved into their respective folders,
main `README.md` only references it.
The `examples` folder is for now removed and replaced partially by the in
documentation examples.
@droguljic droguljic added this to the v2 milestone May 5, 2026
@MiroDojkic
Copy link
Copy Markdown
Member

I think the best test for the docs would be to have someone who hasn't worked much with icb, to try and deploy some of the components just using the docs.
Saying this cause I remember when I had to use it heavily, I quickly reached for the code examples due to documentation not really helping me in an effective way.

- The primary subnet group always uses `vpc.isolatedSubnetIds`, and the database is always created with `publiclyAccessible: false`.
- The database security group allows TCP/5432 from the VPC CIDR block.
- The primary password is always managed through a nested `Password` component. If you omit `password`, that nested component generates a random password and stores it in Secrets Manager.
- `Database` creates replicas sequentially. Each replica depends on the previous primary/replica instance rather than creating all replicas in parallel.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add explanation why it need to create them sequentially?

| `password` | `pulumi.Input<string>` | No | generated by `Password` | If omitted, a nested `Password` component generates and stores the secret. |
| `engineVersion` | `pulumi.Input<string>` | No | `'17.2'` | PostgreSQL engine version. |
| `multiAz` | `pulumi.Input<boolean>` | No | `false` | Multi-AZ toggle for the primary instance. |
| `instanceClass` | `pulumi.Input<string>` | No | `'db.t4g.micro'` | Primary instance class. |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instance type of the RDS instance?

Comment on lines +115 to +118
| `allowMajorVersionUpgrade` | `pulumi.Input<boolean>` | No | `false` | Passed through to the primary instance. |
| `autoMinorVersionUpgrade` | `pulumi.Input<boolean>` | No | `true` | Passed through to the primary instance. |
| `applyImmediately` | `pulumi.Input<boolean>` | No | `false` | Passed through to the primary instance. |
| `skipFinalSnapshot` | `pulumi.Input<boolean>` | No | `false` | Passed through to the primary instance. |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more specific description

Comment on lines +300 to +302
| `applyImmediately` | `pulumi.Input<boolean>` | No | `false` | Passed through to the replica instance. |
| `allowMajorVersionUpgrade` | `pulumi.Input<boolean>` | No | `false` | Passed through to the replica instance. |
| `autoMinorVersionUpgrade` | `pulumi.Input<boolean>` | No | `true` | Passed through to the replica instance. |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more specific description

| `parameterGroupName` | `pulumi.Input<string>` | No | none | Optional DB parameter group name for the primary instance. |
| `kmsKeyId` | `pulumi.Input<string>` | No | generated KMS key ARN | Override for storage encryption and encrypted snapshot copies. |
| `replicaConfigs` | `Map<string, Database.ReplicaConfig>` | No | none | Ordered map of replica names to configs. Replicas are created sequentially in insertion order. |
| `enableSSMConnect` | `pulumi.Input<boolean>` | No | `false` | Creates the nested `Ec2SSMConnect` helper when truthy. |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the wording from helper to something else? It's used on multiple places in the file for Ec2SSMConnect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants