removed redeclarations so it works with ten-A/Types-for-Adobe#20
removed redeclarations so it works with ten-A/Types-for-Adobe#20sbrown345 wants to merge 1 commit intoExtendScript:masterfrom
Conversation
ff6347
left a comment
There was a problem hiding this comment.
Hm. The files *.d.ts are the source for index.d.ts. They all get concatenated using bin/concat.js in the build process. So removing them makes no sense. I guess it would be better if we add them to a .npmignore file so we don't get a redeclaration.
|
I'm only referencing index.d.ts in my project. (Actually just with I meant they are redeclarations of here: https://github.com/ten-A/Types-for-Adobe/blob/master/shared/JavaScript.d.ts#L299 e.g. I'm using the "noLib" TypeScript configuration so I'm relying on the Types-for-Adobe for the rest. (I can't see any other way of doing it.) |
Ah okay. I think it makes no sense to remove them here in just for not having them collide with another repo. I guess others are not using ten-A's "Types-for-Adobe". Maybe something like this can help you keep a sane setup --> https://www.npmjs.com/package/patch-package |
|
Understood, everyone has a different setup. I'll give that a shot, thanks! I got the idea doing it this way just because I was using extendscript-es5-shim-ts at one point, then I noticed the latest commits on this repo, but it wouldn't build. Removing the re-declarations fixed it like on: (Which only declares JSON) |
No description provided.