Merged
Conversation
Member
Author
Member
|
Which functions would you remove ? For sure tests should be run on a real Adobe products, as ExtendScript has it's own things that JS does not. If you could give me some points what could i check to get it working i'll be glad to work on those :) |
Member
Author
|
Well. Well won’t get a CI Server with an ExtendScript engine. That’s why I would set all functions we patch to undefined and let them use our shims. I’ll try to write a test for it. |
Member
|
Seems like a good idea to me then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.