fix: match real DynamoDB on Scan and Query ExclusiveStartKey malformations#86
Merged
pdf-amzn merged 1 commit intoMay 28, 2026
Conversation
Collaborator
|
Hi Anand - Thanks for the PR! Could I ask you to take a look at #66 (which has been merged to main) and see if that resolves some/all of the issues you've covered, or improves on it in areas? Happy to review but would like to understand (and minimize if possible) the overlap. |
Contributor
Author
|
Hello Joel, thanks for taking a look. I did look at #66 and this PR builds on top of it. There are 2 cases from the table that #66 doesn't cover: |
1e0dd66 to
c0f4a13
Compare
pdf-amzn
approved these changes
May 28, 2026
ea0851f to
1237388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tighten ExclusiveStartKey validation in Scan and Query so every malformed request returns ValidationException matching real DynamoDB.
Why
Two malformations are still accepted, where real DynamoDB rejects them:
Wire-format messages are mirrored verbatim:
The provided starting key is invalid: The provided key element does not match the schemaThe provided starting key is invalidBuilds on #66
Testing done
tests/python/test_scan_edge_cases.pycovering the malformations real DynamoDB rejects.Checklist
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic)docs/design/01-requirements.mdalready specifies ValidationException for input validation, this PR makes the implementation match the spec)Breaking changes
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache License 2.0 and I agree to the Developer Certificate of Origin (DCO). See CONTRIBUTING.md for details.