Bootstrapper refactor#144
Open
jcshepherd wants to merge 2 commits into
Open
Conversation
…related out of the Postgres bootstrapper so they can be used by bootstrappers for other db backends
jcshepherd
requested review from
LeeroyHannigan,
amrith,
c33howard and
pdf-amzn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Factors some common functions related to identifiers, passwords, config validation and encryption from the PostgreSQL bootstrapper into the common storage crate for use by other db bootstrappers. Also, delegating engine-specific configuration to the engine's bootstrapper.
Why
Refactoring reduces code duplication across backend plug-ins, and improves consistency. Delegating configuration generation eliminates another PostgreSQL-specific dependency.
Closes #
Testing done
Unit tests, pytests, manual testing with both PostgreSQL and other backend plug-in.
Checklist
cargo test --workspace)cargo fmt --check)cargo clippy -- -W clippy::pedantic)Storagetrait, auth model, on-diskformat, or public CLI surface, an RFC has been accepted or is linked
below. Otherwise, an ADR captures the decision (link below).
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.