Skip to content

fix: unwrap singleton array in tryParseStructuredJsonValue #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gianellichia980-png wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −2
Open

fix: unwrap singleton array in tryParseStructuredJsonValue #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6044cd7
fix: unwrap singleton array in tryParseStructuredJsonValue to handle …
gianellichia980-png Apr 15, 2026
11d008d
fix: detect HTML error pages from relays as transport_error in classi…
gianellichia980-png Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions server/src/llm/structuredInvoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,17 @@ function tryFixTruncatedJson(raw: string): string {
return fixed;
}

function unwrapSingletonArray(val: unknown): unknown {
if (Array.isArray(val) && val.length === 1) {
return val[0];
}
return val;
}

function tryParseStructuredJsonValue(source: string): { parsed: unknown } | { error: string } {
try {
return {
parsed: JSON.parse(extractJSONValue(source)) as unknown,
parsed: unwrapSingletonArray(JSON.parse(extractJSONValue(source))),
};
} catch (error) {
const fixed = tryFixTruncatedJson(source);
Expand All @@ -126,7 +133,7 @@ function tryParseStructuredJsonValue(source: string): { parsed: unknown } | { er

try {
return {
parsed: JSON.parse(extractJSONValue(fixed)) as unknown,
parsed: unwrapSingletonArray(JSON.parse(extractJSONValue(fixed))),
};
} catch (fixedError) {
return {
Expand Down
18 changes: 18 additions & 0 deletions server/src/llm/structuredOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,24 @@ export function classifyStructuredOutputFailure(input: {
if (haystack.includes("zod") || haystack.includes("schema") || haystack.includes("校验错误")) {
return "schema_mismatch";
}
// Relay/proxy returned HTML instead of JSON (e.g. rate limit page, auth error page)
const lowerHaystack = haystack.toLowerCase();
if (
lowerHaystack.includes("<!doctype") ||
lowerHaystack.includes("<html") ||
lowerHaystack.includes("<body") ||
lowerHaystack.includes("</div>") ||
lowerHaystack.includes("</script>") ||
lowerHaystack.includes("rate limit") ||
lowerHaystack.includes("429") ||
lowerHaystack.includes("<title>error") ||
lowerHaystack.includes("<title>403") ||
lowerHaystack.includes("<title>404") ||
lowerHaystack.includes("<title>502") ||
lowerHaystack.includes("<title>503")
) {
return "transport_error";
}
return "transport_error";
}

Expand Down