Skip to content

Upgrade eslint-config-expensify#743

Open
roryabraham wants to merge 3 commits intomainfrom
rory-report-unused-disable-directives
Open

Upgrade eslint-config-expensify#743
roryabraham wants to merge 3 commits intomainfrom
rory-report-unused-disable-directives

Conversation

@roryabraham
Copy link
Copy Markdown
Contributor

Details

Upgrades eslint-config-expensify to a version that includes reportUnusedDisableDirectives: 'error' in the base config. This ensures stale eslint-disable comments that no longer suppress an active rule violation are flagged as errors.

No unused directives were found in this repo, so the only change is the dependency upgrade.

Depends on Expensify/eslint-config-expensify#180

Related Issues

N/A - tooling improvement

Automated Tests

N/A - lint config change only

Manual Tests

  1. Run npx eslint . and verify no Unused eslint-disable directive errors appear
  2. Verify existing lint behavior is unchanged

Author Checklist

  • I linked the correct issue in the ### Related Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
  • I followed the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A - no UI changes

Made with Cursor

Upgrades to a version that sets reportUnusedDisableDirectives: 'error'.
No unused directives were found in this repo.

Made-with: Cursor
@roryabraham roryabraham changed the title Upgrade eslint-config-expensify to report unused disable directives [HOLD] Upgrade eslint-config-expensify to report unused disable directives Mar 2, 2026
@Julesssss Julesssss self-requested a review April 9, 2026 22:27
Julesssss
Julesssss previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can come off hold now @roryabraham, we could bump to version 2.0.106

@roryabraham roryabraham marked this pull request as ready for review April 11, 2026 01:58
@roryabraham roryabraham requested a review from a team as a code owner April 11, 2026 01:58
@roryabraham roryabraham changed the title [HOLD] Upgrade eslint-config-expensify to report unused disable directives Upgrade eslint-config-expensify Apr 11, 2026
@melvin-bot melvin-bot bot requested review from pecanoro and removed request for a team April 11, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants