Implement debouncing for scheduleScan in autoLoadMoreComments#348
Open
iwiznia wants to merge 1 commit into
Open
Implement debouncing for scheduleScan in autoLoadMoreComments#348iwiznia wants to merge 1 commit into
iwiznia wants to merge 1 commit into
Conversation
Debounce the scheduleScan function to limit execution frequency.
Contributor
|
I tested this out on rust-lang/rfcs#2544... It did not seem to be working. I didn't have any issues with For this screenshot, I loaded the page, scrolled down to the first "load more..." and clicked on it once. The "scan" log only fired when the page loaded though. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debounce the scheduleScan function to limit execution frequency.
I tried to add console.log to see the debounce in action, but for some reason I could not see any logs (even though code was running). I think it should work anyway...