Skip to content

Add suspicious_transactions_detected fraud state constants#916

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-addSuspiciousTransactionsFraudStates
Closed

Add suspicious_transactions_detected fraud state constants#916
MelvinBot wants to merge 1 commit into
mainfrom
claude-addSuspiciousTransactionsFraudStates

Conversation

@MelvinBot
Copy link
Copy Markdown

Add SUSPICIOUS_TRANSACTIONS_DETECTED (11), SUSPICIOUS_TRANSACTIONS_DETECTED_CLEARED (12), and SUSPICIOUS_TRANSACTIONS_DETECTED_CONFIRMED (13) to CONST.EXPENSIFY_CARD.FRAUD_STATES to match the PHP-Libs constants added in Auth. These are needed by Web-Expensify to replace hardcoded numeric literals.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/623745

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review"

Add SUSPICIOUS_TRANSACTIONS_DETECTED (11), SUSPICIOUS_TRANSACTIONS_DETECTED_CLEARED (12), and SUSPICIOUS_TRANSACTIONS_DETECTED_CONFIRMED (13) to CONST.EXPENSIFY_CARD.FRAUD_STATES to match the PHP-Libs constants.

Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team May 21, 2026 18:25
@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@madmax330 madmax330 marked this pull request as ready for review May 21, 2026 18:31
@madmax330
Copy link
Copy Markdown
Contributor

I have read the CLA Document and I hereby sign the CLA

@melvin-bot melvin-bot Bot requested review from deetergp and removed request for a team May 21, 2026 18:31
@madmax330
Copy link
Copy Markdown
Contributor

recheck

@madmax330
Copy link
Copy Markdown
Contributor

@MelvinBot can you post a comment on this PR with the following text: "I have read the CLA Document and I hereby sign the CLA"

@madmax330
Copy link
Copy Markdown
Contributor

@MelvinBot can you post a comment on this PR with the following text: "I have read the CLA Document and I hereby sign the CLA"

@madmax330
Copy link
Copy Markdown
Contributor

Closing in favor of: #917

@madmax330 madmax330 closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants