Skip to content

Perf: Defer Search/Reports list mount via NavigationDeferredMount#91848

Open
dariusz-biela wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:dariusz-biela/perf/search/navigation-deferred-mount
Open

Perf: Defer Search/Reports list mount via NavigationDeferredMount#91848
dariusz-biela wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:dariusz-biela/perf/search/navigation-deferred-mount

Conversation

@dariusz-biela
Copy link
Copy Markdown
Contributor

@dariusz-biela dariusz-biela commented May 27, 2026

Explanation of Change

Warm start of the Reports/Search page (first render in a session, data already cached) takes ~550ms (Mac M4 Pro) because we wait for the full list to render before showing anything to the user. This PR applies NavigationDeferredMount to that path so the warm start behaves like a cold start visually:

  • On first mount of SearchPage, a SearchRowSkeleton placeholder paints immediately and ends ManualNavigateToReports with is_warm: true.
  • The heavy Search subtree mounts inside startTransition after the navigation transition completes, so the list does not compete with the navigation animation frame budget.
  • Subsequent navigations to the same tab (react-freeze cache hit) re-use the already-mounted Search, do not show the skeleton, and end the span via the existing useFocusEffect — that path still measures to list visible.

Implementation:

  • New src/components/Search/SearchWithNavigationDeferredMount.tsx. Accepts ComponentProps<typeof Search>, picks the placeholder container style from useResponsiveLayout() + props.hasFilterBars, and spreads props to Search.
  • SearchPageWide and SearchPageNarrow (non-static branch) render SearchWithNavigationDeferredMount instead of Search directly. The static-rendering branch in SearchPageNarrow (post-submit overlay path) is left untouched.

Results:

image

Warm full - this is the time it takes for the first warm render to display the full list, rather than just the skeleton.

Fixed Issues

$ #91731
PROPOSAL:

Tests

  1. Log in.
  2. Cold start — In Troubleshoot, run "Reset Onyx", refresh the page, then navigate to the Reports page. Verify the page-level skeleton is shown until data arrives, then the list renders.
  3. Warm start, first render — Go to Home, refresh the page, then navigate to the Reports page. Verify a skeleton briefly paints before the list appears.
  4. Warm start, cached render — Go to Home, then back to the Reports page. Verify the list shows immediately without a skeleton.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-05-27.at.16.46.29.mp4
iOS: Native
Screen.Recording.2026-05-27.at.16.42.14.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-05-27.at.16.36.52.mp4

Introduce SearchWithNavigationDeferredMount that wraps Search in
NavigationDeferredMount with a SearchRowSkeleton placeholder. The placeholder
ends the ManualNavigateToReports span with is_warm=true at first layout, so
warm first mount measures to skeleton visible while the heavy list hydrates
after the navigation transition completes. Refocus through react-freeze still
ends the span via Search's existing useFocusEffect, so cached navigations
keep measuring to list visible without showing a skeleton.

Used by SearchPageWide and SearchPageNarrow (non-static branch) in place of
the previous inline render so the spread-props wrapper handles narrow vs wide
container styling internally via useResponsiveLayout.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/Search/SearchPageNarrow/index.tsx 73.33% <ø> (ø)
src/pages/Search/SearchPageWide.tsx 0.00% <ø> (ø)
...nents/Search/SearchWithNavigationDeferredMount.tsx 12.50% <12.50%> (ø)
... and 67 files with indirect coverage changes

@dariusz-biela dariusz-biela marked this pull request as ready for review May 27, 2026 14:58
@dariusz-biela dariusz-biela requested review from a team as code owners May 27, 2026 14:58
@melvin-bot melvin-bot Bot requested review from a team, JmillsExpensify and marufsharifi and removed request for a team May 27, 2026 14:58
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 27, 2026

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from luacmartins and mananjadhav and removed request for a team May 27, 2026 14:58
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 27, 2026

@mananjadhav @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant