Pass policyID when issuing physical Expensify Cards#91843
Draft
MelvinBot wants to merge 1 commit into
Draft
Conversation
The physical card branch in issueExpensifyCard() was not including policyID in the API parameters, causing Bedrock to resolve the workspace from domainAccountID instead of using the active policy. This led to users being auto-invited to the wrong workspace. Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When issuing a physical Expensify Card,
issueExpensifyCard()was not includingpolicyIDin the API parameters sent viaCREATE_EXPENSIFY_CARD. The virtual card branch (CREATE_ADMIN_ISSUED_VIRTUAL_CARD) already correctly includedpolicyID. This caused Bedrock to resolve the workspace fromdomainAccountIDinstead of using the active policy, which led to card assignees being auto-invited to the wrong workspace.This one-line fix adds
policyIDto the physical card API call parameters, matching the virtual card behavior.Depends on Auth PR that removes the mutual exclusion check between
policyIDanddomainAccountIDinCreateExpensifyCard.cpp.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/636080
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari