[HOLD] Patch victory-native with explicitSize + headless props#91836
[HOLD] Patch victory-native with explicitSize + headless props#91836roryabraham wants to merge 3 commits into
Conversation
Mirrors FormidableLabs/victory-native-xl#657 into victory-native@41.20.2 via patch-package so Metro (src/) and Bun/Node (dist/) both receive the headless chart rendering API ahead of an upstream release. Co-authored-by: Cursor <cursoragent@cursor.com>
📲 Install BuildsAndroid
|
Keep horizontal-bars as +001 from main. Rename our patch to +002+explicit-size-headless and document both in patches/victory-native/details.md. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0656398204
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| + const { width, height } = canvasSize; | ||
| + | ||
| + return ( | ||
| + <GestureHandlerRootView> |
There was a problem hiding this comment.
Preserve the wrapper flex for Polar charts
This shared wrapper is now used by PolarChart after removing Polar's outer flex container and its GestureHandlerRootView style={{flex: 1, overflow: "hidden"}}, but the replacement root has no size/flex style. In the existing Top Merchants pie chart (src/components/Charts/PieChart/PieChartContent.tsx) PolarChart is rendered inside a fixed-height parent without passing explicitSize, so this root can collapse instead of filling the chart area and prevent the canvas from receiving a usable layout. Please put the flex/overflow style on the GestureHandlerRootView (or otherwise keep the old flex container) for the non-headless path.
Useful? React with 👍 / 👎.
|
Throwing this on HOLD since the upstream PR was just merged! |
|
Ah nice! |
Summary
Upgrades victory-native.
Fixed Issues
For #91528
Tests
Spend->Insights->Spend over timeand make sure the line graph renders correctly.Spend->Insights->Top Merchantsand make sure the pie chart renders correctly.Offline tests
n/a
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots
Cartesian:

Polar:
