[HR Import] Route HR fix connection Time Sensitive notifications to the Workspace HR page by mhawryluk · Pull Request #91813 · Expensify/App

mhawryluk · 2026-05-27T09:42:48Z

Explanation of Change

The Time Sensitive section on the home page surfaces a "Fix" CTA for every broken policy connection. Previously every broken connection: accounting (QBO, Xero etc.) and HR (Gusto, Zenefits, Merge HR) was rendered by FixAccountingConnection, which hard-coded navigation to ROUTES.WORKSPACE_ACCOUNTING. A user with a broken Gusto/Zenefits/Merge HR connection would click "Fix" and land on the Accounting page, now they're correctly routed to the HR page. Also fixes the title of the menu to use the provider name for merge HR connections (Workday, BambooHR...) instead of "Merge HR".

Fixed Issues

$ #91712
PROPOSAL: N/A

Tests

Open an account which has a workspace with a failed HR connection.
Go to the home page.
Verify in the Time sensitive section there is an item saying Fix connection (not a generic Fix Merge HR connection, but Bamboo/Workday/HiBob).
Click on the Fix button.
Verify you are navigated to the workspace's HR tab. (the beta needs to be enabled to see the page).

also:

Open an account which has a workspace with a failed Accounting connection.
Go to the home page.
Verify in the Time sensitive section there is an item saying Fix connection.
Click on the Fix button.
Verify you are navigated to the workspace's Accounting tab.

Offline tests

N/A

QA Steps

Open an account which has a workspace with a failed Accounting connection.
Go to the home page.
Verify in the Time sensitive section there is an item saying Fix connection.
Click on the Fix button.
Verify you are navigated to the workspace's Accounting tab.

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-05-27.o.11.45.04.mov

…onnection types to their respective pages

melvin-bot · 2026-05-27T09:42:55Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-05-27T09:52:46Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/home/TimeSensitiveSection/index.tsx	`70.23% <60.00%> (-1.72%)`	⬇️
...TimeSensitiveSection/items/FixPolicyConnection.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

melvin-bot · 2026-05-27T10:03:37Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e69dc55580

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-27T10:07:39Z

+        : translate('homePage.timeSensitiveSection.fixPolicyConnection.defaultSubtitle');
+
+    const isHRConnection = (CONST.POLICY.CONNECTIONS.HR_CONNECTION_NAMES as readonly PolicyConnectionName[]).includes(connectionName);
+    const fixRoute = isHRConnection ? ROUTES.WORKSPACE_HR.getRoute(policyID) : ROUTES.WORKSPACE_ACCOUNTING.getRoute(policyID);


Gate HR fix CTAs before routing to HR

When this renders for a broken HR connection, the CTA now always navigates to WORKSPACE_HR, but WorkspaceHRPage is blocked unless an HR beta is enabled (shouldBeBlocked) and the policy passes the control/admin access wrapper. TimeSensitiveSection only filters adminPolicies, so admins who can see this time-sensitive item without the HR beta/control access will land on the not-found page instead of somewhere they can fix the connection; either hide the HR item in those contexts or route to an accessible fallback.

Useful? React with 👍 / 👎.

I guess we could, but we don't check for a beta when navigating to the HR page from Members and Workflows pages when a provider is connected. so I think it's okay here too

I think it's fine too, since a user can have a broken connection only if they have a beta

mhawryluk · 2026-05-27T10:29:35Z

@bernhardoj will review this one (merge.dev project)

bernhardoj · 2026-05-27T11:41:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

[HR Import] Route Time Sensitive notifications for different policy c…

a013e09

…onnection types to their respective pages

melvin-bot Bot assigned mhawryluk May 27, 2026

Merge branch 'main' into merge-hr/route-time-sensitive

e69dc55

mhawryluk marked this pull request as ready for review May 27, 2026 10:03

mhawryluk requested review from a team as code owners May 27, 2026 10:03

melvin-bot Bot requested review from flaviadefaria and sobitneupane and removed request for a team May 27, 2026 10:03

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

bernhardoj approved these changes May 27, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia May 27, 2026 12:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HR Import] Route HR fix connection Time Sensitive notifications to the Workspace HR page#91813

[HR Import] Route HR fix connection Time Sensitive notifications to the Workspace HR page#91813
mhawryluk wants to merge 2 commits into
Expensify:mainfrom
software-mansion-labs:merge-hr/route-time-sensitive

mhawryluk commented May 27, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

codecov Bot commented May 27, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Uh oh!

mhawryluk May 27, 2026 •

edited

Loading

Uh oh!

bernhardoj May 27, 2026

Uh oh!

mhawryluk commented May 27, 2026 •

edited

Loading

Uh oh!

bernhardoj commented May 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mhawryluk commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

codecov Bot commented May 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 27, 2026

Choose a reason for hiding this comment

Uh oh!

mhawryluk commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mhawryluk commented May 27, 2026 •

edited

Loading

codecov Bot commented May 27, 2026 •

edited by github-actions Bot

Loading

mhawryluk May 27, 2026 •

edited

Loading

mhawryluk commented May 27, 2026 •

edited

Loading

bernhardoj commented May 27, 2026 •

edited

Loading