#2 - Update advanced filters button to open filters popover by bernhardoj · Pull Request #91806 · Expensify/App

bernhardoj · 2026-05-27T08:56:15Z

Explanation of Change

Fixed Issues

$ #84877
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace with report fields

Web

Go to the Spend page
Press the Filters button
Verify the advanced filter popover opens
Hover over any filter
For a selection-based filter, press any of the selections and verify that the filter is applied
For a text input-based filter, enter anything, press Apply, and verify the filter is applied
For a date-based filter, press Custom date or Custom range, apply the value, and verify the filter is applied
For an amount-based filter, select any option and verify that a text input is shown below the selection
Choose between and verify a greater than and less than text inputs are shown
Apply any selection and value, and verify the filter is applied
Open a report field filter, open any field and verify the filter is applied only after pressing the Apply button

mWeb, Android, iOS

Go to the Spend page
Press the Filters button
Verify the advanced filter opens in full screen
Verify there is an Apply button and there is no Reset button at the footer
Press any filter
Verify it shows the selected filter
Set any value and press Apply
Verify it goes back to the filter list
Press Apply again and verify the filters are applied
Press the Filters button
Verify there is a Reset button
Press Reset
Verify the filter is reset

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

…mer pass the type and policyID

…uch cheaper

…evert-filter-popup" This reverts commit 8c53336, reversing changes made to 02ec137.

…l screens

melvin-bot · 2026-05-27T08:56:23Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63f2565bfa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…rs-popup

dubielzyk-expensify · 2026-05-27T09:35:42Z

I think we spoke about having more spacing above the search fields when they appear? 20px?

Otherwise it's looking pretty good to me. Curious to do an adhoc too

bernhardoj · 2026-05-27T09:43:52Z

Yeah, we did, it's the old recordings 😅

Let's spin an adhoc build

github-actions · 2026-05-27T09:54:41Z

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-27T10:00:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91806.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cfef3f152d9-0146af9-6d53119bee57fd4a6c5793a50f11db83b87cfa5c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cfef3f1-0146af9-d48553a829698ebd96b06c94933e95879cc34b40/index.html

Web 🕸️
https://91806.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

bernhardoj · 2026-05-27T10:09:43Z

        });
    });
+
+    describe('getKeywordQueryWithCurrentSearchContext', () => {


This is removed from the revert PR, so added it back here.

dubielzyk-expensify · 2026-05-27T10:11:26Z

Do we want auto-focus here @trjExpensify and @Expensify/design ?

CleanShot.2026-05-27.at.20.06.40.mp4

Also every other "search" field has Search as the label but category says category.

(I realize some of these things are perhaps outside of this PR or maybe mentioned before, but I'm just mentioning it 😅)

I think we also need to do something about this in a follow-up cause it's not obvious that there's a to date here:

Part of me also wanna auto-close the popover when applying a filter, but I worry a bit about how annoying it could for those who wanna apply many filters. I might lean to do it, but I don't feel strongly so curious what @Expensify/design thinks.

@bernhardoj amazing job on this btw. Always such high quality and attention to detail. Really appreciate it!

bernhardoj · 2026-05-27T10:23:43Z

Do we want auto-focus here

The previous discussion was that we only auto-focus on the full-screen view. Fixed it.

codecov · 2026-05-27T10:33:02Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.84% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
...rc/components/Icon/chunks/expensify-icons.chunk.ts	`0.00% <ø> (ø)`
...s/AdvancedFilters/useFullscreenAdvancedFilters.tsx	`100.00% <100.00%> (ø)`
...mponents/Search/FilterDropdowns/DropdownButton.tsx	`88.88% <100.00%> (ø)`
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx	`0.00% <ø> (ø)`
...h/SearchPageHeader/SearchDisplayDropdownButton.tsx	`75.00% <100.00%> (-18.34%)`	⬇️
...Search/SearchPageHeader/SearchFiltersBarNarrow.tsx	`70.00% <100.00%> (+1.57%)`	⬆️
...c/components/Search/hooks/useUpdateFilterQuery.tsx	`40.00% <ø> (+9.23%)`	⬆️
...ents/Table/TableFilterButtons/buildFilterItems.tsx	`47.45% <ø> (ø)`
... and 54 more
... and 92 files with indirect coverage changes

shawnborton · 2026-05-27T11:32:46Z

I'm pretty torn on closing or not - I can see an argument that you might want to keep adding filters instead of just one, but it's really hard to know for sure. I would probably leave it open until the user clicks outside?

Agree where you both landed on auto-focus as well.

aimane-chnaif · 2026-05-27T14:46:05Z

Are we still waiting on feedback or more to fix yet? Or ready for review?

bernhardoj · 2026-05-27T15:12:30Z

Ready for review

aimane-chnaif · 2026-05-27T16:39:37Z

+    SEARCH_ADVANCED_FILTERS_CONTENT: {
+        route: 'search/filters/:filterKey',
+        getRoute: (filterKey: SearchFilterKey | UserFriendlyKey) => `search/filters/${filterKey}` as const,
+    },


For mobile view, any reason for not using existing legacy filter pages?

App/src/ROUTES.ts

Lines 747 to 756 in 52e1696

SEARCH_ADVANCED_FILTERS: {

route: 'search/filters/:filterKey?/:subPage?',

getRoute: (filterKey?: SearchFilterKey | UserFriendlyKey, subPage?: string) => {

const baseRoute = `search/filters/${filterKey ?? ''}` as const;

if (!subPage || !filterKey) {

return baseRoute;

}

return `${baseRoute}/${subPage}` as const;

},

},

As we're going with navigation path, why not just reorder filter menu items in old filters page but completely refactored?

aimane-chnaif · 2026-05-27T17:05:44Z

Bug: janky animation when open amount filter

diff.mov

luacmartins

Let's make sure that all blockers are fixed #91684

aimane-chnaif · 2026-05-27T17:27:35Z

Let's make sure that all blockers are fixed #91684

Regarding No receipt tooltip in Has filter, we're still discussing expected behavior in #91683 (comment)

bernhardoj added 11 commits May 26, 2026 15:55

remove unnecessary code from useAdvancedSearchFilters

05a6eef

fix filter list doesn't change when type changes by letting the consu…

b627c69

…mer pass the type and policyID

improve the selector so it returns string so the comparison becomes m…

4f1419b

…uch cheaper

Revert "Merge pull request Expensify#91721 from Expensify/jsenyitko-r…

8176a7b

…evert-filter-popup" This reverts commit 8c53336, reversing changes made to 02ec137.

remove unused prop

389fde4

migrate the advanced filters from modal to navigation screens on smal…

ec78f4d

…l screens

fix filter list is not updated after changing type

488913a

remove unused component

dc76d0b

add press on enter

86e965f

sort list

99b8cc5

don't show modal when not focused

63f2565

bernhardoj requested review from a team as code owners May 27, 2026 08:56

melvin-bot Bot assigned bernhardoj May 27, 2026

melvin-bot Bot requested review from aimane-chnaif and trjExpensify and removed request for a team May 27, 2026 08:56

melvin-bot Bot removed the request for review from a team May 27, 2026 08:56

github-actions Bot reviewed May 27, 2026

View reviewed changes

Comment thread src/components/SafeTriangle/index.tsx

github-actions Bot reviewed May 27, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/BaseSearchList/index.tsx Outdated

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

Comment thread src/pages/Search/SearchAdvancedFiltersContentPage/SearchAdvancedFiltersContentBase.tsx Outdated

Merge branch 'main' into feat/84877-update-filters-chip-to-open-filte…

07f60b0

…rs-popup

use existing selector

a908324

bernhardoj added 3 commits May 27, 2026 17:47

show not found when filter key is invalid

5747db2

fix test

cfef3f1

add missing import

68b8524

reorganize and lint

b028ce9

bernhardoj commented May 27, 2026

View reviewed changes

bernhardoj added 3 commits May 27, 2026 18:15

fix spelling

1f6e4a0

fix type

6ed6fc3

fix autofocus

e59fb90

bernhardoj added 2 commits May 27, 2026 20:22

lint

122ac92

lint

a47d510

aimane-chnaif reviewed May 27, 2026

View reviewed changes

JS00001 self-requested a review May 27, 2026 17:01

luacmartins reviewed May 27, 2026

View reviewed changes

	SEARCH_ADVANCED_FILTERS: {
	route: 'search/filters/:filterKey?/:subPage?',
	getRoute: (filterKey?: SearchFilterKey \| UserFriendlyKey, subPage?: string) => {
	const baseRoute = `search/filters/${filterKey ?? ''}` as const;
	if (!subPage \|\| !filterKey) {
	return baseRoute;
	}
	return `${baseRoute}/${subPage}` as const;
	},
	},

Conversation

bernhardoj commented May 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dubielzyk-expensify commented May 27, 2026

Uh oh!

bernhardoj commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

bernhardoj May 27, 2026

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented May 27, 2026

Uh oh!

bernhardoj commented May 27, 2026

Uh oh!

codecov Bot commented May 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnborton commented May 27, 2026

Uh oh!

aimane-chnaif commented May 27, 2026

Uh oh!

bernhardoj commented May 27, 2026

Uh oh!

aimane-chnaif May 27, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif May 27, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented May 27, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented May 27, 2026 •

edited

Loading