[No QA] Add bank account validation & wallet troubleshooting edge cases#91788
[No QA] Add bank account validation & wallet troubleshooting edge cases#91788MelvinBot wants to merge 2 commits into
Conversation
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
ITIN (Individual Taxpayer Identification Number) is used in the bank account docs but was not in the spell-check word list. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing spellcheck: added |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@amyevans @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cbe6a834e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| If Onfido could not verify your identity: | ||
|
|
||
| 1. Make sure the photo of your ID is clear, well-lit, and shows all four corners of the document. | ||
| 2. Use a valid, non-expired government-issued photo ID (passport, driver's license, or national ID card). |
There was a problem hiding this comment.
Remove unavailable national ID option from Onfido guidance
For users troubleshooting the New Expensify Onfido flow on web, this suggests retrying with a national ID card even though the app config only exposes driving_licence for the USA and passport in src/components/Onfido/BaseOnfidoWeb.tsx lines 87-93. Those users won't be able to select the document type the article recommends, so the guidance can send already-failing verification attempts down a dead end; keep this list limited to the document types the flow actually offers.
Useful? React with 👍 / 👎.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
amyevans
left a comment
There was a problem hiding this comment.
I suppose it triggered an engineering review due to the change in cspell.json? Anyway, changes look good from my perspective, I'll leave the Concierge review to you @Kel-Expensify!
Summary
Related: Expensify/Expensify#637958
Articles updated
docs/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account.md- Added troubleshooting section for validation edge cases (wrong amounts, missing Fix button, temporary locks, expiration, delayed test transactions)docs/articles/new-expensify/wallet-and-payments/Resolve-Errors-Adding-a-Bank-Account.md- Expanded with structured sections for Onfido failures, beneficial owner docs, industry restrictions, and documentation review processdocs/articles/new-expensify/wallet-and-payments/Set-up-your-wallet.md- Added troubleshooting for wallet pending state, verification failures, and enabled-but-not-working scenariosdocs/articles/expensify-classic/bank-accounts-and-payments/bank-accounts/Troubleshooting-business-bank-account-setups.md- Added validation failure edge cases and documentation review troubleshootingTest plan