Skip to content

[No QA] Pin react-native-onyx to PR #792 head for retry-idempotency end-to-end testing #91626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elirangoshen wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

[No QA] Pin react-native-onyx to PR #792 head for retry-idempotency end-to-end testing #91626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"react-native-localize": "^3.5.4",
"react-native-nitro-modules": "0.35.0",
"react-native-nitro-sqlite": "9.6.0",
"react-native-onyx": "3.0.73",
"react-native-onyx": "git+https://github.com/callstack-internal/react-native-onyx.git#de62ae5eae69a4aaf0b1b734e408ba5db2a9c79b",
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid pinning dependency to private GitHub repository

Pointing react-native-onyx to github.com/callstack-internal/... makes installs depend on access to that private repo, so npm install/npm ci will fail for contributors, forks, and CI jobs that do not have those credentials. This effectively blocks anyone outside the authorized org from reproducing the build or running tests, which is a release-blocking regression compared to consuming a public npm tag or public commit source.

Useful? React with 👍 / 👎.

"react-native-pager-view": "8.0.0",
"react-native-pdf": "7.0.2",
"react-native-permissions": "^5.4.0",
Expand Down
Loading